Skip to content

Commit deeff7b

Browse files
authored
Merge pull request #1298 from dhensby/pulls/bulk-error
Catch errors from table._makeBulk()
2 parents eca8c40 + 8226880 commit deeff7b

File tree

2 files changed

+10
-2
lines changed

2 files changed

+10
-2
lines changed

lib/msnodesqlv8/request.js

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -146,7 +146,11 @@ class Request extends BaseRequest {
146146
super._bulk(table, options, err => {
147147
if (err) return callback(err)
148148

149-
table._makeBulk()
149+
try {
150+
table._makeBulk()
151+
} catch (e) {
152+
return callback(new RequestError(e, 'EREQUEST'))
153+
}
150154

151155
if (!table.name) {
152156
setImmediate(callback, new RequestError('Table name must be specified for bulk insert.', 'ENAME'))

lib/tedious/request.js

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -213,7 +213,11 @@ class Request extends BaseRequest {
213213
super._bulk(table, options, err => {
214214
if (err) return callback(err)
215215

216-
table._makeBulk()
216+
try {
217+
table._makeBulk()
218+
} catch (e) {
219+
return callback(new RequestError(e, 'EREQUEST'))
220+
}
217221

218222
if (!table.name) {
219223
return callback(new RequestError('Table name must be specified for bulk insert.', 'ENAME'))

0 commit comments

Comments
 (0)