Skip to content

Commit

Permalink
dt-bindings: mfd: bd71828: Use charger resistor in mOhm instead of MOhm
Browse files Browse the repository at this point in the history
Apparently there was some confusion regarding milliohm vs. megaohm.
(m/M). Use microohms to be able to properly specify the charger
resistor like other drivers do. This is not used yet by mainline code
yet. Specify a current sense resistor in milliohms range rather then
megaohms range in the examples.

CC: sre@kernel.org
Reported-by: Matti Vaittinen <mazziesaccount@gmail.com>
Closes: https://lore.kernel.org/imx/6dcd724a-a55c-4cba-a45b-21e76b1973b0@gmail.com/T/#mf590875a9f4d3955cd1041d7196ff0c65c0a7e9d
Signed-off-by: Andreas Kemnade <andreas@kemnade.info>
Reviewed-by: Matti Vaittinen <mazziesaccount@gmail.com>
Acked-by: Conor Dooley <conor.dooley@microchip.com>
Reviewed-by: Sebastian Reichel <sebastian.reichel@collabora.com>
Fixes: 1af5332 ("dt-bindings: mfd: Document ROHM BD71828 bindings")
Link: https://lore.kernel.org/r/20241111102701.358133-1-andreas@kemnade.info
Signed-off-by: Lee Jones <lee@kernel.org>
  • Loading branch information
akemnade authored and lag-linaro committed Nov 12, 2024
1 parent 131a975 commit 8ece9d2
Showing 1 changed file with 7 additions and 6 deletions.
13 changes: 7 additions & 6 deletions Documentation/devicetree/bindings/mfd/rohm,bd71828-pmic.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -55,14 +55,15 @@ properties:
minimum: 0
maximum: 1

rohm,charger-sense-resistor-ohms:
minimum: 10000000
maximum: 50000000
rohm,charger-sense-resistor-micro-ohms:
minimum: 10000
maximum: 50000
default: 30000
description: |
BD71827 and BD71828 have SAR ADC for measuring charging currents.
External sense resistor (RSENSE in data sheet) should be used. If some
other but 30MOhm resistor is used the resistance value should be given
here in Ohms.
other but 30mOhm resistor is used the resistance value should be given
here in microohms.
regulators:
$ref: /schemas/regulator/rohm,bd71828-regulator.yaml
Expand Down Expand Up @@ -114,7 +115,7 @@ examples:
#gpio-cells = <2>;
gpio-reserved-ranges = <0 1>, <2 1>;
rohm,charger-sense-resistor-ohms = <10000000>;
rohm,charger-sense-resistor-micro-ohms = <10000>;
regulators {
buck1: BUCK1 {
Expand Down

0 comments on commit 8ece9d2

Please sign in to comment.