-
-
Notifications
You must be signed in to change notification settings - Fork 132
Add cpp basics #83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add cpp basics #83
Conversation
β Deploy Preview for quicksnip ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, thanks for the contribution, please take a quick look at the comment I left, we can then move on with your snippet.
@@ -39,7 +39,7 @@ | |||
}, | |||
{ | |||
"title": "Split String", | |||
"description": "Splits a string by a delimiter", | |||
"description": "Splits a string by a delimiter.", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please remove the .
you added here
"code": [ | ||
"#include <string>", | ||
"", | ||
"// Function to check if a given string is a palindrome", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comments are generally not required in the snippet.
Except for the one in line 73, I don't think others are required.
Even that one is too obvious, but I think is fine, people sometimes don't realize that could be an option.
to be consistent with the palindrome snippet of other languages, you should check a lowercased version of the string. |
Hey, we recently updated how snippets are stored, please update your PR to match the changes, you will be able to see how to add snippets in |
Closing this as stale. |
Description
Added a new C++ snippet under the String Manipulation category, which checks if a given string is a palindrome.
Type of Change
Checklist
Related Issues
Closes #
Additional Context
Screenshots (Optional)
Click to view screenshots