Skip to content

Commit 62d325a

Browse files
authored
Merge pull request #65 from technocreatives/fix/duplicate-name
fix duplicate enum names on multiplex messages
2 parents 8fcb8ca + 606159f commit 62d325a

File tree

3 files changed

+11
-11
lines changed

3 files changed

+11
-11
lines changed

src/lib.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1145,7 +1145,7 @@ fn multiplex_enum_name(msg: &Message, multiplexor: &Signal) -> Result<String> {
11451145
multiplexor
11461146
);
11471147
Ok(format!(
1148-
"{}{}",
1148+
"{}{}Index",
11491149
msg.message_name().to_pascal_case(),
11501150
multiplexor.name().to_pascal_case()
11511151
))

testing/can-messages/src/messages.rs

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1182,14 +1182,14 @@ impl MultiplexTest {
11821182
u8::from(signal).saturating_mul(factor).saturating_add(0)
11831183
}
11841184

1185-
pub fn multiplexor(&mut self) -> Result<MultiplexTestMultiplexor, CanError> {
1185+
pub fn multiplexor(&mut self) -> Result<MultiplexTestMultiplexorIndex, CanError> {
11861186
match self.multiplexor_raw() {
1187-
0 => Ok(MultiplexTestMultiplexor::M0(MultiplexTestMultiplexorM0 {
1188-
raw: self.raw,
1189-
})),
1190-
1 => Ok(MultiplexTestMultiplexor::M1(MultiplexTestMultiplexorM1 {
1191-
raw: self.raw,
1192-
})),
1187+
0 => Ok(MultiplexTestMultiplexorIndex::M0(
1188+
MultiplexTestMultiplexorM0 { raw: self.raw },
1189+
)),
1190+
1 => Ok(MultiplexTestMultiplexorIndex::M1(
1191+
MultiplexTestMultiplexorM1 { raw: self.raw },
1192+
)),
11931193
multiplexor => Err(CanError::InvalidMultiplexor {
11941194
message_id: 200,
11951195
multiplexor: multiplexor.into(),
@@ -1313,7 +1313,7 @@ impl<'a> Arbitrary<'a> for MultiplexTest {
13131313
}
13141314
/// Defined values for multiplexed signal MultiplexTest
13151315
#[derive(Debug)]
1316-
pub enum MultiplexTestMultiplexor {
1316+
pub enum MultiplexTestMultiplexorIndex {
13171317
M0(MultiplexTestMultiplexorM0),
13181318
M1(MultiplexTestMultiplexorM1),
13191319
}

testing/can-messages/tests/all.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
#![allow(clippy::float_cmp)]
22

33
use can_messages::{
4-
Amet, Bar, BarThree, CanError, Foo, MultiplexTest, MultiplexTestMultiplexor,
4+
Amet, Bar, BarThree, CanError, Foo, MultiplexTest, MultiplexTestMultiplexorIndex,
55
MultiplexTestMultiplexorM0,
66
};
77

@@ -69,7 +69,7 @@ fn pack_unpack_message_containing_multiplexed_signals() {
6969
assert_eq!(result.unmultiplexed_signal(), 2);
7070
assert_eq!(result.multiplexor_raw(), 0);
7171
let multiplexor = result.multiplexor().unwrap();
72-
if let MultiplexTestMultiplexor::M0(m0) = multiplexor {
72+
if let MultiplexTestMultiplexorIndex::M0(m0) = multiplexor {
7373
assert_eq!(m0.multiplexed_signal_zero_a(), 1.2);
7474
assert_eq!(m0.multiplexed_signal_zero_b(), 2.0);
7575
} else {

0 commit comments

Comments
 (0)