Skip to content

Commit 4aa6ea2

Browse files
committed
fix(SelectField|MenuItem): Restore scrollIntoView for highlighted item due to reactivity regression. Resolves #553
1 parent b7cc4f5 commit 4aa6ea2

File tree

2 files changed

+9
-1
lines changed

2 files changed

+9
-1
lines changed

.changeset/stale-jokes-bow.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
'svelte-ux': patch
3+
---
4+
5+
fix(SelectField|MenuItem): Restore `scrollIntoView` for highlighted item due to reactivity regression. Resolves #553

packages/svelte-ux/src/lib/components/MenuItem.svelte

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,14 +36,17 @@
3636
3737
// Clear theme to not expose to Button
3838
settings({ ...getSettings(), components: {} });
39+
40+
// Needs variable to restore reactivity.
41+
$: actions = (node: HTMLElement) => [scrollIntoViewAction(node, scrollOptions)];
3942
</script>
4043

4144
<Button
4245
variant="none"
4346
{icon}
4447
{classes}
4548
fullWidth
46-
actions={(node) => [scrollIntoViewAction(node, scrollOptions)]}
49+
{actions}
4750
{disabled}
4851
{...$$restProps}
4952
class={cls(

0 commit comments

Comments
 (0)