[TEC-62] Create EC2 instance for GitLab provisioning #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[TEC-62] Create EC2 instance for GitLab provisioning
techiescamp
reviewed
Jul 18, 2023
Owner
techiescamp
left a comment
techiescamp
left a comment
There was a problem hiding this comment.
Security Group should be created with the ec2 instance.
Create a sg module and use that module in ec2 resources.
In vars, we should be able to pass the ports and inbound CIDRs
techiescamp
requested changes
Jul 18, 2023
Owner
techiescamp
left a comment
techiescamp
left a comment
There was a problem hiding this comment.
Instance name should be derived from tag values
techiescamp
approved these changes
Jul 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes Made: