Merge pull request #18 from Aswin-Vijayan/master

[CD-5][Changes] - Made required changes in alb, asg and iam policy

Author: techiescamp

README.md

@@ -22,20 +22,56 @@ terraform destroy \
     -backend-config="dynamodb_table=terraform-state-lock"
 ```
 
-## RDS Provisioning
+#### RDS Provisioning
 
 cd into the `environments/dev/rds` directory and run the following commands:
 
+1. Init Terraform in the directory `environments/dev/rds`
+
 ```
 terraform init
+```
+2. To preview the changes in code
 
+```
 terraform plan -var-file=../../../vars/dev/rds.tfvars
+```
+3. To apply the changes
 
+```
 terraform apply -var-file=../../../vars/dev/rds.tfvars
+```
+4. To destroy the resources created using the code
 
+```
 terraform destroy -var-file=../../../vars/dev/rds.tfvars
 ```
 
+### ALB and ASG Provisioning
+
+cd into the `environments/dev/alb-asg` directory and run the following commands:
+
+1. Init Terraform in the directory `environments/dev/alb-asg`
+
+```
+terraform init
+```
+2. To preview the changes in code
+
+```
+terraform plan -var-file=../../../vars/dev/alb-asg.tfvars
+```
+3. To apply the changes
+
+```
+terraform apply -var-file=../../../vars/dev/alb-asg.tfvars
+```
+4. To destroy the resources created using the code
+
+```
+terraform destroy -var-file=../../../vars/dev/alb-asg.tfvars
+```
+
 ## EC2 Instance Provisioning
 
 1. Navigate to the `environment/dev` folder:

environments/dev/alb-asg/main.tf

@@ -4,7 +4,10 @@ provider "aws" {
 
 module "iam-policy" {
   source                          = "../../../modules/iam-policy"
-  instance_role                   = var.instance_role
+  owner                           = var.owner
+  environment                     = var.environment
+  cost_center                     = var.cost_center
+  application                     = var.application
 }
 
 module "alb-sg" {
@@ -14,7 +17,7 @@ module "alb-sg" {
   environment                     = var.environment
   owner                           = var.owner
   cost_center                     = var.cost_center
-  application                     = var.application
+  application                     ="${var.application}-alb"
   vpc_id                          = var.vpc_id
   ingress_from_port               = var.alb_ingress_from_port
   ingress_to_port                 = var.alb_ingress_to_port
@@ -32,7 +35,7 @@ module "alb" {
   internal                        = var.internal
   loadbalancer_type               = var.loadbalancer_type
   vpc_id                          = var.vpc_id
-  subnets                         = var.subnets
+  alb_subnets                     = var.alb_subnets
   target_group_port               = var.target_group_port
   target_group_protocol           = var.target_group_protocol
   target_type                     = var.target_type
@@ -75,13 +78,11 @@ module "instance-sg" {
 
 module "asg" {
   source                          = "../../../modules/asg"
-  instance_profile                = var.instance_profile
-  instance_role                   = var.instance_role
   ami_id                          = var.ami_id
   instance_type                   = var.instance_type
   key_name                        = var.key_name
   vpc_id                          = var.vpc_id
-  subnets                         = var.subnets
+  asg_subnets                     = var.asg_subnets
   public_access                   = var.public_access
   user_data                       = var.user_data
   max_size                        = var.max_size
@@ -92,7 +93,7 @@ module "asg" {
   environment                     = var.environment
   cost_center                     = var.cost_center
   application                     = var.application
-  alb_target_group_arn            = module.alb.lb_target_group_arn
+  alb_target_group_arn            = module.alb.alb_target_group_arn
   iam_role                        = module.iam-policy.iam_role
   security_group_ids              = module.instance-sg.security_group_ids
   tags = {

environments/dev/alb-asg/variables.tf

@@ -9,16 +9,6 @@ variable "region" {
   description = "Region of the alb-asg"
 }
 
-variable "instance_profile" {
-  description = "Instance profile for the instance which the instance role is associated with"
-  type        = string
-}
-
-variable "instance_role" {
-  description = "Instance role for the instance"
-  type        = string
-}
-
 variable "internal" {
   description = "Whether the load balancer is internal or not"
   type        = bool
@@ -29,6 +19,11 @@ variable "loadbalancer_type" {
   type        = string
 }
 
+variable "alb_subnets" {
+  description = "A list of subnet IDs to use for the resources."
+  type        = list(string)
+}
+
 variable "target_group_port" {
   description = "Target group port"
   type        = number
@@ -120,7 +115,7 @@ variable "vpc_id" {
   description = "The ID of the VPC to use for the resources."
 }
 
-variable "subnets" {
+variable "asg_subnets" {
   description = "A list of subnet IDs to use for the resources."
   type        = list(string)
 }
@@ -221,9 +216,6 @@ variable "egress_protocol" {
   type        = list(any)
 }
 
-#####
-
-
 variable "alb_ingress_cidr_block" {
   type        = list(string)
   description = "CIDR blocks for EC2 security group ingress rules"

environments/dev/file/lb-asg.json renamed to environments/dev/iam-policies/alb-asg.json

@@ -1,14 +1,14 @@
-resource "aws_lb" "application_load_balancer" {
-  name               = "${var.environment}-${var.application}-lb"
+resource "aws_alb" "application_load_balancer" {
+  name               = "${var.environment}-${var.application}-alb"
   internal           = var.internal
   load_balancer_type = var.loadbalancer_type
 
-  subnets         = var.subnets
+  subnets         = var.alb_subnets
   security_groups = var.security_group_ids
 
   tags = merge(
     {
-      Name        = "${var.environment}-${var.application}-lb",
+      Name        = "${var.environment}-${var.application}-alb",
       Environment = var.environment,
       Owner       = var.owner,
       CostCenter  = var.cost_center,
@@ -18,7 +18,7 @@ resource "aws_lb" "application_load_balancer" {
   )
 }
 
-resource "aws_lb_target_group" "alb_tg" {
+resource "aws_alb_target_group" "alb_tg" {
   name_prefix = "alb-tg"
   port        = var.target_group_port
   protocol    = var.target_group_protocol
@@ -39,7 +39,7 @@ resource "aws_lb_target_group" "alb_tg" {
 
   tags = merge(
     {
-      Name        = "${var.environment}-${var.application}-lb-target-group"
+      Name        = "${var.environment}-${var.application}-alb-target-group"
       Environment = var.environment,
       Owner       = var.owner,
       CostCenter  = var.cost_center,
@@ -49,13 +49,13 @@ resource "aws_lb_target_group" "alb_tg" {
   )
 }
 
-resource "aws_lb_listener" "application_listener" {
-  load_balancer_arn = aws_lb.application_load_balancer.arn
+resource "aws_alb_listener" "application_listener" {
+  load_balancer_arn = aws_alb.application_load_balancer.arn
   port              = var.listener_port
   protocol          = var.listener_protocol
 
   default_action {
-    target_group_arn = aws_lb_target_group.alb_tg.arn
+    target_group_arn = aws_alb_target_group.alb_tg.arn
     type             = var.listener_type
   }
 }

modules/alb/main.tf

@@ -1,9 +1,9 @@
 output "load_balancer_dns_name" {
   description = "LoadBalancer dns name"
-  value = aws_lb.application_load_balancer.dns_name
+  value = aws_alb.application_load_balancer.dns_name
 }
 
-output "lb_target_group_arn" {
-  description = "LB Target Grouparn"
-  value = aws_lb_target_group.alb_tg.arn
+output "alb_target_group_arn" {
+  description = "ALB Target Grouparn"
+  value = aws_alb_target_group.alb_tg.arn
 }

modules/alb/outputs.tf

@@ -29,7 +29,7 @@ variable "vpc_id" {
   description = "The ID of the VPC to use for the resources."
 }
 
-variable "subnets" {
+variable "alb_subnets" {
   description = "A list of subnet IDs to use for the resources."
   type        = list(string)
 }

modules/alb/variables.tf

@@ -6,7 +6,7 @@ locals {
 }
 
 resource "aws_iam_instance_profile" "instance_profile" {
-  name = var.instance_profile
+  name = "${var.environment}-${var.application}-instance_profile"
 
   role = var.iam_role
 }
@@ -18,7 +18,7 @@ resource "aws_launch_template" "application_lt" {
   key_name      = var.key_name
 
   iam_instance_profile {
-    name = var.instance_profile
+    name = "${var.environment}-${var.application}-instance_profile"
   }
 
   network_interfaces {
@@ -35,7 +35,7 @@ resource "aws_autoscaling_group" "application_asg" {
   max_size            = var.max_size
   min_size            = var.min_size
   desired_capacity    = var.desired_capacity
-  vpc_zone_identifier = var.subnets
+  vpc_zone_identifier = var.asg_subnets
 
   launch_template {
     id      = aws_launch_template.application_lt.id

modules/asg/main.tf

@@ -4,13 +4,8 @@ variable "tags" {
   description = "Extra tags to attach to the alb-asg resources"
 }
 
-variable "instance_profile" {
-  description = "Instance profile for the instance which the instance role is associated with"
-  type        = string
-}
-
-variable "instance_role" {
-  description = "Instance role for the instance"
+variable "iam_role" {
+  description = "IAM role for the instance"
   type        = string
 }
 
@@ -34,7 +29,7 @@ variable "vpc_id" {
   description = "The ID of the VPC to use for the resources."
 }
 
-variable "subnets" {
+variable "asg_subnets" {
   description = "A list of subnet IDs to use for the resources."
   type        = list(string)
 }
@@ -98,8 +93,3 @@ variable "alb_target_group_arn" {
   description = "load balancer target group arn"
   type        = string
 }
-
-variable "iam_role" {
-  description = "iam role name"
-  type        = string
-}

modules/asg/variables.tf

@@ -1,5 +1,5 @@
 resource "aws_iam_role" "iam_role" {
-  name = var.instance_role
+  name = "${var.environment}-${var.application}-iam-role"
   assume_role_policy = jsonencode({
     Version = "2012-10-17"
     Statement = [
@@ -12,11 +12,21 @@ resource "aws_iam_role" "iam_role" {
       }
     ]
   })
+  tags = merge(
+    {
+      Name        = "${var.environment}-${var.application}-iam-role",
+      Environment = var.environment,
+      Owner       = var.owner,
+      CostCenter  = var.cost_center,
+      Application = var.application
+    },
+    var.tags
+  )
 }
 
 resource "aws_iam_policy" "iam_policy" {
-  name = "iam_policy"
-  policy = file("${path.module}../../../environments/dev/file/lb-asg.json")
+  name = "${var.environment}-${var.application}-iam-policy"
+  policy = file("${path.module}../../../environments/dev/iam-policies/alb-asg.json")
 }
 
 resource "aws_iam_role_policy_attachment" "iam_role_policy_attachment" {