Skip to content

Commit 93b5c38

Browse files
committed
appx: Use a different resource for the Properties DisplayName (microsoft#12337)
We have to do this so that the store sees us as one thing ("Windows Terminal") and the Start menu sees us as another ("Terminal"). The store will reject our package if the value we use for "DisplayName" here doesn't match the store's "reserved names". This value is *not used* by the start menu. (cherry picked from commit e064c15)
1 parent 1aab365 commit 93b5c38

File tree

4 files changed

+13
-3
lines changed

4 files changed

+13
-3
lines changed

src/cascadia/CascadiaPackage/Package-Dev.appxmanifest

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@
2020
Version="0.0.1.0" />
2121

2222
<Properties>
23-
<DisplayName>ms-resource:TerminalApp/ContextMenu/AppNameDev</DisplayName>
23+
<DisplayName>ms-resource:TerminalApp/ContextMenu/AppStoreNameDev</DisplayName>
2424
<PublisherDisplayName>A Lone Developer</PublisherDisplayName>
2525
<Logo>Images\StoreLogo.png</Logo>
2626
</Properties>

src/cascadia/CascadiaPackage/Package-Pre.appxmanifest

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@
2121
Version="0.5.0.0" />
2222

2323
<Properties>
24-
<DisplayName>ms-resource:TerminalApp/ContextMenu/AppNamePre</DisplayName>
24+
<DisplayName>ms-resource:TerminalApp/ContextMenu/AppStoreNamePre</DisplayName>
2525
<PublisherDisplayName>Microsoft Corporation</PublisherDisplayName>
2626
<Logo>Images\StoreLogo.png</Logo>
2727
</Properties>

src/cascadia/CascadiaPackage/Package.appxmanifest

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@
2121
Version="1.0.0.0" />
2222

2323
<Properties>
24-
<DisplayName>ms-resource:TerminalApp/ContextMenu/AppName</DisplayName>
24+
<DisplayName>ms-resource:TerminalApp/ContextMenu/AppStoreName</DisplayName>
2525
<PublisherDisplayName>Microsoft Corporation</PublisherDisplayName>
2626
<Logo>Images\StoreLogo.png</Logo>
2727
</Properties>

src/cascadia/TerminalApp/Resources/en-US/ContextMenu.resw

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -127,6 +127,16 @@
127127
<data name="AppNamePre" xml:space="preserve">
128128
<value>Terminal Preview</value>
129129
</data>
130+
<data name="AppStoreName" xml:space="preserve">
131+
<value>Windows Terminal</value>
132+
</data>
133+
<data name="AppStoreNameDev" xml:space="preserve">
134+
<value>Windows Terminal Dev</value>
135+
<comment>{Locked} The dev build will never be seen in multiple languages</comment>
136+
</data>
137+
<data name="AppStoreNamePre" xml:space="preserve">
138+
<value>Windows Terminal Preview</value>
139+
</data>
130140
<data name="AppShortName" xml:space="preserve">
131141
<value>Terminal</value>
132142
</data>

0 commit comments

Comments
 (0)