Accept a full secret address for advanced connection #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blinry
commented
Nov 9, 2025
src/services/node_service.rs
Outdated
Comment on lines
68
to
69
| if peer_secret_address.len() != 2 { | ||
| bail!("peer_secret_address does not have the format <node_id>#<passphrase>") |
Contributor
Author
There was a problem hiding this comment.
Currently, this verification fails, I'm not sure why!
Contributor
Author
There was a problem hiding this comment.
Ah, because it was supposed to be parts.len(). :D Fixed, and ready for review!
Contributor
Author
There was a problem hiding this comment.
(@winniehell, requesting your review without expectations you get to it soon! But this is a nice quality-of-life improvement for me!)
blinry
force-pushed
the
accept-full-secret-address
branch
from
5da7026 to
dabf742
Compare
winniehell
approved these changes
Nov 10, 2025
This should make it a bit easier to test, because you don't need to copy the individual parts of the secret address.
blinry
force-pushed
the
accept-full-secret-address
branch
from
dabf742 to
5f1831a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should make it a bit easier to test, because you don't need to copy the individual parts of the secret address.