Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests are broken because pytest>=8.0.0 breaks pytest-lazy-fixture #11

Closed
uermel opened this issue May 16, 2024 · 0 comments · Fixed by #12
Closed

Tests are broken because pytest>=8.0.0 breaks pytest-lazy-fixture #11

uermel opened this issue May 16, 2024 · 0 comments · Fixed by #12

Comments

@uermel
Copy link
Collaborator

uermel commented May 16, 2024

pytest==8.0.0 was released after the last test-and-deploy. It is incompatible with pytest-lazy-fixture (see TvoroG/pytest-lazy-fixture#65), causing tests to fail.

To reproduce:

conda create -n imodmodel_test python==3.11
conda activate imodmodel_test
git clone https://github.com/teamtomo/imodmodel.git
cd imodmodel
pip install ".[dev]"
pytest

Fails with:

E   pluggy.PluggyTeardownRaisedWarning: A plugin raised an exception during an old-style hookwrapper teardown.
E   Plugin: lazy-fixture, Hook: pytest_generate_tests
E   AttributeError: 'CallSpec2' object has no attribute 'funcargs'
E   For more information see https://pluggy.readthedocs.io/en/stable/api_reference.html#pluggy.PluggyTeardownRaisedWarning

As that plugin doesn't seem to be in development anymore it would likely be good to adopt any of the workarounds mentioned in that issue to fix the tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant