Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(eslint) - update plugins and adjust eslint configs #8707

Merged
merged 5 commits into from
Mar 26, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 37 additions & 3 deletions .bitmap
Original file line number Diff line number Diff line change
Expand Up @@ -490,7 +490,24 @@
"scope": "teambit.envs",
"version": "1.0.207",
"mainFile": "index.ts",
"rootDir": "scopes/envs/env"
"rootDir": "scopes/envs/env",
"config": {
"teambit.dependencies/dependency-resolver": {
"policy": {
"dependencies": {
"@typescript-eslint/parser": "7.1.0",
"@typescript-eslint/eslint-plugin": "7.1.0",
"eslint-plugin-jest": "27.6.3",
"eslint-plugin-import": "2.29.1",
"eslint-plugin-react-hooks": "4.6.0",
"eslint-plugin-react": "7.33.2",
"eslint-plugin-jsx-a11y": "6.8.0",
"eslint-plugin-mdx": "1.17.1",
"eslint-mdx": "1.17.1"
}
}
}
}
},
"envs": {
"name": "envs",
Expand Down Expand Up @@ -1029,7 +1046,24 @@
"scope": "teambit.harmony",
"version": "1.0.207",
"mainFile": "index.ts",
"rootDir": "scopes/harmony/node"
"rootDir": "scopes/harmony/node",
"config": {
"teambit.dependencies/dependency-resolver": {
"policy": {
"dependencies": {
"@typescript-eslint/parser": "7.1.0",
"@typescript-eslint/eslint-plugin": "7.1.0",
"eslint-plugin-jest": "27.6.3",
"eslint-plugin-import": "2.29.1",
"eslint-plugin-react-hooks": "4.6.0",
"eslint-plugin-react": "7.33.2",
"eslint-plugin-jsx-a11y": "6.8.0",
"eslint-plugin-mdx": "1.17.1",
"eslint-mdx": "1.17.1"
}
}
}
}
},
"notifications": {
"name": "notifications",
Expand Down Expand Up @@ -1998,4 +2032,4 @@
"rootDir": "scopes/dependencies/yarn"
},
"$schema-version": "17.0.0"
}
}
2 changes: 2 additions & 0 deletions components/ui/inputs/lane-selector_1/lane-menu-item.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,8 @@ export type LaneMenuItemProps = {
timestamp?: Date;
} & HTMLAttributes<HTMLDivElement>;

// TODO: @luv please fix the eslint error
// eslint-disable-next-line react/display-name
export const LaneMenuItem = forwardRef<HTMLDivElement, LaneMenuItemProps>(
(
{
Expand Down
6 changes: 3 additions & 3 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -288,11 +288,11 @@
"eslint": "8.56.0",
"eslint-config-prettier": "8.5.0",
"eslint-plugin-import": "2.29.1",
"eslint-plugin-jsx-a11y": "6.4.1",
"eslint-plugin-jsx-a11y": "6.8.0",
"eslint-plugin-mocha": "6.3.0",
"eslint-plugin-promise": "4.3.1",
"eslint-plugin-react": "7.22.0",
"eslint-plugin-react-hooks": "4.2.0",
"eslint-plugin-react": "7.33.2",
"eslint-plugin-react-hooks": "4.6.0",
"gh-release": "3.5.0",
"husky": "7.0.4",
"lint-staged": "^12.5.0",
Expand Down
981 changes: 579 additions & 402 deletions pnpm-lock.yaml

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion scopes/defender/eslint/component.json
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
"teambit.dependencies/dependency-resolver": {
"policy": {
"devDependencies": {
"@types/eslint": "7.28.0"
"@types/eslint": "8.56.6"
},
"dependencies": {
"@babel/runtime": "7.23.2"
Expand Down
2 changes: 2 additions & 0 deletions scopes/defender/eslint/eslint.main.runtime.ts
Original file line number Diff line number Diff line change
Expand Up @@ -92,6 +92,8 @@ function getOptions(options: ESLintOptions, context: LinterContext): ESLintOptio
overrideConfig: options.config,
extensions: context.extensionFormats,
useEslintrc: false,
// TODO: this should be probably be replaced with resolve-plugins-relative-to
// https://eslint.org/docs/latest/use/command-line-interface#--resolve-plugins-relative-to
cwd: options.pluginPath,
fix: !!context.fix,
fixTypes: context.fixTypes,
Expand Down
2 changes: 1 addition & 1 deletion scopes/react/eslint-config-bit-react/component.json
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@
"@teambit/legacy": "-"
},
"peerDependencies": {
"eslint": "> 7.0.0",
"eslint": "> 8.0.0",
"@teambit/legacy": "1.0.675"
}
}
Expand Down
11 changes: 6 additions & 5 deletions scopes/react/react/component.json
Original file line number Diff line number Diff line change
Expand Up @@ -15,12 +15,13 @@
"@typescript-eslint/parser": "7.1.0",
"@typescript-eslint/eslint-plugin": "7.1.0",
"esbuild": "0.14.29",
"eslint-plugin-jest": "24.1.5",
"eslint-plugin-import": "2.22.1",
"eslint-plugin-react-hooks": "4.2.0",
"eslint-plugin-react": "7.22.0",
"eslint-plugin-jsx-a11y": "6.4.1",
"eslint-plugin-jest": "27.6.3",
"eslint-plugin-import": "2.29.1",
"eslint-plugin-react-hooks": "4.6.0",
"eslint-plugin-react": "7.33.2",
"eslint-plugin-jsx-a11y": "6.8.0",
"eslint-plugin-mdx": "1.17.1",
"eslint-mdx": "1.17.1",
"@mdx-js/react": "1.6.22",
"jest-environment-jsdom": "27.5.1",
"sanitize.css": "12.0.1",
Expand Down
2 changes: 1 addition & 1 deletion workspace.jsonc
Original file line number Diff line number Diff line change
Expand Up @@ -323,7 +323,7 @@
"@types/cors": "2.8.10",
"@types/dagre": "0.7.44",
"@types/didyoumean": "1.2.0",
"@types/eslint": "7.28.0",
"@types/eslint": "8.56.6",
"@types/express": "4.17.13",
"@types/find-root": "1.1.2",
"@types/lodash.compact": "3.0.6",
Expand Down