From 1e7bd9fab5401a2df18d2eabd802adcf0dcf1f15 Mon Sep 17 00:00:00 2001 From: Jonathan Leitschuh Date: Sat, 19 Nov 2022 03:00:26 +0000 Subject: [PATCH] vuln-fix: Temporary File Information Disclosure This fixes temporary file information disclosure vulnerability due to the use of the vulnerable `File.createTempFile()` method. The vulnerability is fixed by using the `Files.createTempFile()` method which sets the correct posix permissions. Weakness: CWE-377: Insecure Temporary File Severity: Medium CVSSS: 5.5 Detection: CodeQL & OpenRewrite (https://public.moderne.io/recipes/org.openrewrite.java.security.SecureTempFileCreation) Reported-by: Jonathan Leitschuh Signed-off-by: Jonathan Leitschuh Bug-tracker: https://github.com/JLLeitschuh/security-research/issues/18 Co-authored-by: Moderne --- src/main/java/org/apache/mahout/pig/LogisticRegression.java | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/main/java/org/apache/mahout/pig/LogisticRegression.java b/src/main/java/org/apache/mahout/pig/LogisticRegression.java index 17af842..ff6953d 100644 --- a/src/main/java/org/apache/mahout/pig/LogisticRegression.java +++ b/src/main/java/org/apache/mahout/pig/LogisticRegression.java @@ -38,6 +38,7 @@ import org.apache.pig.impl.util.UDFContext; import java.io.*; +import java.nio.file.Files; import java.util.Iterator; import java.util.List; import java.util.Map; @@ -159,7 +160,7 @@ public LogisticRegression(String modelParams) throws IOException { } if (!inMemory) { - tmpFile = File.createTempFile("trainingData", "tmp"); + tmpFile = Files.createTempFile("trainingData", "tmp").toFile(); tmpFile.deleteOnExit(); } }