Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support SVG previews #949

Open
revolunet opened this issue Mar 26, 2024 · 2 comments
Open

Support SVG previews #949

revolunet opened this issue Mar 26, 2024 · 2 comments
Labels
enhancement New feature or request web

Comments

@revolunet
Copy link
Contributor

revolunet commented Mar 26, 2024 •
edited
Loading

Your use case

What would you like to do?

Be able to preview SVGs files in Tchap

Why would you like to do it?

Because SVGs is a useful format

How would you like to achieve it?

Help land a PR to make it work :)

Have you considered any alternatives?

No response

Additional context

Maybe this is a security issue ?
@revolunet revolunet added enhancement New feature or request web labels Mar 26, 2024
@estellecomment
Copy link
Contributor

An old issue in element-web mentions that this is unsupported because of billion-lols attack :
https://en.wikipedia.org/wiki/Billion_laughs_attack
element-hq/element-web#2008

So we would need to sanitize SVGs.

What is your use case ? Is this a real life problem or a theoretical problem ?

@revolunet
Copy link
Contributor Author

ok thanks; SVG support is a nice-to-have because SVGs are easy to generate, slims, and can be animated.

Example:

Tchap

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request web
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@revolunet @estellecomment