Skip to content

Test gap for invalid string calendar IDs #3896

Open
@justingrant

Description

@justingrant

Codecov found that there's no test coverage for invalid calendar string IDs, e.g. "notacal" in the following AOs:

  • ToRelativeTemporalObject
  • ToTemporalMonthDay
  • ToTemporalYearMonth
  • ToTemporalZonedDateTime

These AOs are used in a lot of places, so I'm not sure which test files need to be changed or added (likely 100s of them), but here's a few code samples as a starting point:

Temporal.Duration.from('P1M').add({months: 2}, {relativeTo: "2020-01-01[u-ca=notacal]"} );
Temporal.PlainMonthDay.from("2020-01-01[u-ca=notacal]");
Temporal.PlainYearMonth.from("2020-01-01[u-ca=notacal]");
Temporal.ZonedDateTime.from("2020-01-01[UTC][u-ca=notacal]");

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions