Merge and extract for tests in PlainDate/prototype

Author: Brage Hogstad

test/built-ins/Temporal/PlainDate/prototype/equals/argument-propertybag-calendar-invalid-iso-string.js

@@ -0,0 +1,23 @@
+// Copyright (C) 2025 Igalia, S.L. All rights reserved.
+// This code is governed by the BSD license found in the LICENSE file.
+
+/*---
+esid: sec-temporal.plaindate.prototype.equals
+description: Invalid ISO string as calendar should throw RangeError
+features: [Temporal]
+---*/
+
+const instance = new Temporal.PlainDate(2000, 5, 2);
+
+const invalidStrings = [
+  ["", "empty string"],
+];
+
+for (const [calendar, description] of invalidStrings) {
+  const arg = { year: 1976, monthCode: "M11", day: 18, calendar };
+  assert.throws(
+    RangeError,
+    () => instance.equals(arg),
+    `${description} is not a valid calendar ID`
+  );
+}

test/built-ins/Temporal/PlainDate/prototype/equals/argument-propertybag-calendar-number.js

@@ -9,23 +9,24 @@ description: >
 features: [BigInt, Symbol, Temporal]
 ---*/
 
-const timeZone = "UTC";
 const instance = new Temporal.PlainDate(2000, 5, 2);
 
 const primitiveTests = [
   [null, "null"],
   [true, "boolean"],
-  ["", "empty string"],
-  [1, "number that doesn't convert to a valid ISO string"],
+  [1, "number"],
   [1n, "bigint"],
+  [19970327, "large number"],
+  [-19970327, "negative number"],
+  [1234567890, "very large integer"],
 ];
 
 for (const [calendar, description] of primitiveTests) {
-  const arg = { year: 2019, monthCode: "M11", day: 1, calendar };
+  const arg = { year: 1976, monthCode: "M11", day: 18, calendar };
   assert.throws(
-    typeof calendar === 'string' ? RangeError : TypeError,
+    TypeError,
     () => instance.equals(arg),
-    `${description} does not convert to a valid ISO string`
+    `${description} is not a valid calendar`
   );
 }
 
@@ -37,5 +38,9 @@ const typeErrorTests = [
 
 for (const [calendar, description] of typeErrorTests) {
   const arg = { year: 2019, monthCode: "M11", day: 1, calendar };
-  assert.throws(TypeError, () => instance.equals(arg), `${description} is not a valid property bag and does not convert to a string`);
+  assert.throws(
+    TypeError,
+    () => instance.equals(arg),
+    `${description} is not a valid property bag and does not convert to a string`
+  );
 }

test/built-ins/Temporal/PlainDate/prototype/equals/argument-propertybag-calendar-wrong-type.js

@@ -0,0 +1,23 @@
+// Copyright (C) 2025 Igalia, S.L. All rights reserved.
+// This code is governed by the BSD license found in the LICENSE file.
+
+/*---
+esid: sec-temporal.plaindate.prototype.since
+description: Invalid ISO string as calendar should throw RangeError
+features: [Temporal]
+---*/
+
+const instance = new Temporal.PlainDate(2000, 5, 2);
+
+const invalidStrings = [
+  ["", "empty string"],
+];
+
+for (const [calendar, description] of invalidStrings) {
+  const arg = { year: 1976, monthCode: "M11", day: 18, calendar };
+  assert.throws(
+    RangeError,
+    () => instance.since(arg),
+    `${description} is not a valid calendar ID`
+  );
+}

test/built-ins/Temporal/PlainDate/prototype/since/argument-propertybag-calendar-invalid-iso-string.js

@@ -14,17 +14,19 @@ const instance = new Temporal.PlainDate(2000, 5, 2);
 const primitiveTests = [
   [null, "null"],
   [true, "boolean"],
-  ["", "empty string"],
-  [1, "number that doesn't convert to a valid ISO string"],
+  [1, "number"],
   [1n, "bigint"],
+  [19970327, "large number"],
+  [-19970327, "negative number"],
+  [1234567890, "very large integer"],
 ];
 
 for (const [calendar, description] of primitiveTests) {
-  const arg = { year: 2019, monthCode: "M11", day: 1, calendar };
+  const arg = { year: 1976, monthCode: "M11", day: 18, calendar };
   assert.throws(
-    typeof calendar === 'string' ? RangeError : TypeError,
+    TypeError,
     () => instance.since(arg),
-    `${description} does not convert to a valid ISO string`
+    `${description} is not a valid calendar`
   );
 }
 
@@ -36,5 +38,9 @@ const typeErrorTests = [
 
 for (const [calendar, description] of typeErrorTests) {
   const arg = { year: 2019, monthCode: "M11", day: 1, calendar };
-  assert.throws(TypeError, () => instance.since(arg), `${description} is not a valid property bag and does not convert to a string`);
+  assert.throws(
+    TypeError,
+    () => instance.since(arg),
+    `${description} is not a valid property bag and does not convert to a string`
+  );
 }

test/built-ins/Temporal/PlainDate/prototype/since/argument-propertybag-calendar-number.js

@@ -0,0 +1,23 @@
+// Copyright (C) 2025 Igalia, S.L. All rights reserved.
+// This code is governed by the BSD license found in the LICENSE file.
+
+/*---
+esid: sec-temporal.plaindate.prototype.until
+description: Invalid ISO string as calendar should throw RangeError
+features: [Temporal]
+---*/
+
+const instance = new Temporal.PlainDate(2000, 5, 2);
+
+const invalidStrings = [
+  ["", "empty string"],
+];
+
+for (const [calendar, description] of invalidStrings) {
+  const arg = { year: 1976, monthCode: "M11", day: 18, calendar };
+  assert.throws(
+    RangeError,
+    () => instance.until(arg),
+    `${description} is not a valid calendar ID`
+  );
+}

test/built-ins/Temporal/PlainDate/prototype/since/argument-propertybag-calendar-wrong-type.js

@@ -9,23 +9,24 @@ description: >
 features: [BigInt, Symbol, Temporal]
 ---*/
 
-const timeZone = "UTC";
 const instance = new Temporal.PlainDate(2000, 5, 2);
 
 const primitiveTests = [
   [null, "null"],
   [true, "boolean"],
-  ["", "empty string"],
-  [1, "number that doesn't convert to a valid ISO string"],
+  [1, "number"],
   [1n, "bigint"],
+  [19970327, "large number"],
+  [-19970327, "negative number"],
+  [1234567890, "very large integer"],
 ];
 
 for (const [calendar, description] of primitiveTests) {
-  const arg = { year: 2019, monthCode: "M11", day: 1, calendar };
+  const arg = { year: 1976, monthCode: "M11", day: 18, calendar };
   assert.throws(
-    typeof calendar === 'string' ? RangeError : TypeError,
+    TypeError,
     () => instance.until(arg),
-    `${description} does not convert to a valid ISO string`
+    `${description} is not a valid calendar`
   );
 }
 
@@ -37,5 +38,9 @@ const typeErrorTests = [
 
 for (const [calendar, description] of typeErrorTests) {
   const arg = { year: 2019, monthCode: "M11", day: 1, calendar };
-  assert.throws(TypeError, () => instance.until(arg), `${description} is not a valid property bag and does not convert to a string`);
+  assert.throws(
+    TypeError,
+    () => instance.until(arg),
+    `${description} is not a valid property bag and does not convert to a string`
+  );
 }

test/built-ins/Temporal/PlainDate/prototype/until/argument-propertybag-calendar-invalid-iso-string.js

@@ -1,25 +1,22 @@
-// Copyright (C) 2022 Igalia, S.L. All rights reserved.
+// Copyright (C) 2025 Igalia, S.L. All rights reserved.
 // This code is governed by the BSD license found in the LICENSE file.
 
 /*---
 esid: sec-temporal.plaindate.prototype.withcalendar
-description: A number is not allowed to be a calendar
+description: Invalid ISO string as calendar should throw RangeError
 features: [Temporal]
 ---*/
 
 const instance = new Temporal.PlainDate(1976, 11, 18, "iso8601");
 
-const numbers = [
-  1,
-  -19761118,
-  19761118,
-  1234567890,
+const invalidStrings = [
+  ["", "empty string"],
 ];
 
-for (const arg of numbers) {
+for (const [arg, description] of invalidStrings) {
   assert.throws(
-    TypeError,
+    RangeError,
     () => instance.withCalendar(arg),
-    "A number is not a valid ISO string for Calendar"
+    `${description} is not a valid calendar ID`
   );
 }

test/built-ins/Temporal/PlainDate/prototype/until/argument-propertybag-calendar-number.js

@@ -14,16 +14,18 @@ const instance = new Temporal.PlainDate(1976, 11, 18, "iso8601");
 const primitiveTests = [
   [null, "null"],
   [true, "boolean"],
-  ["", "empty string"],
-  [1, "number that doesn't convert to a valid ISO string"],
+  [1, "number"],
   [1n, "bigint"],
+  [-19761118, "negative number"],
+  [19761118, "large positive number"],
+  [1234567890, "very large integer"],
 ];
 
 for (const [arg, description] of primitiveTests) {
   assert.throws(
-    typeof arg === 'string' ? RangeError : TypeError,
+    TypeError,
     () => instance.withCalendar(arg),
-    `${description} does not convert to a valid ISO string`
+    `${description} is not a valid calendar`
   );
 }
 
@@ -34,5 +36,9 @@ const typeErrorTests = [
 ];
 
 for (const [arg, description] of typeErrorTests) {
-  assert.throws(TypeError, () => instance.withCalendar(arg), `${description} is not a valid object and does not convert to a string`);
+  assert.throws(
+    TypeError,
+    () => instance.withCalendar(arg),
+    `${description} is not a valid object and does not convert to a string`
+  );
 }