Move DisposeResources to Evaluation of FunctionStatementList #178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rbuckton
added
the
needs-consensus
|
A preview of this PR can be found at https://tc39.es/proposal-explicit-resource-management/pr/178. |
|
This was approved by consensus at the July, 2023 TC39 Plenary, but still needs reviews from the editors and reviewers before I can merge. @waldemarhorwat, @syg, @michaelficarra, @bakkot: can you please review? |
rbuckton
added
the
has-consensus
michaelficarra
approved these changes
Aug 22, 2023
|
@waldemarhorwat, @syg: Could one of you review? |
|
This has also been merged in to rbuckton/ecma262#3 |
rbuckton
added a commit
to rbuckton/ecma262
that referenced
this pull request
May 23, 2024
rbuckton
added a commit
to rbuckton/ecma262
that referenced
this pull request
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves the
DisposeResourcescalls from the abstract closures inEvaluateFunctionBody,GeneratorStart,AsyncGeneratorStart, andAsyncBlockStartto theEvaluationofFunctionStatementList. This centralizes the disposal logic for all function types and avoids the complexity of handling functions created from Abstract Closures that do not currently establish a proper declarative environment.This change is based on findings discovered while writing Test262 tests and implementing this proposal in Engine262.
Fixes #176
Fixes #177
cc: @tc39/ecma262-editors