Normative: add option to omit padding #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I support this addition. |
|
This got consensus; landing, but I do still need to update test262 tests. |
ljharb
reviewed
Jun 11, 2024
Comment on lines
+29
to
+31
| test('omitPadding', async t => { | ||
| for (let [string, result] of standardBase64Vectors) { | ||
| await t.test(JSON.stringify(string), () => { |
There was a problem hiding this comment.
nbd, but why is this async? isn't this all sync?
There was a problem hiding this comment.
I just find it easier to always await everything in node:test rather than thinking about which things need it.
ljharb
added a commit
to es-shims/es-arraybuffer-base64
that referenced
this pull request
Jun 12, 2024
ljharb
added a commit
to es-shims/es-arraybuffer-base64
that referenced
this pull request
Jul 8, 2024
i3roly
pushed a commit
to i3roly/firefox-dynasty
that referenced
this pull request
Jul 13, 2024
…ype.toBase64. r=spidermonkey-reviewers,dminor Changes from: tc39/proposal-arraybuffer-base64#60 Differential Revision: https://phabricator.services.mozilla.com/D216279
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Jul 13, 2024
…ype.toBase64. r=spidermonkey-reviewers,dminor Changes from: tc39/proposal-arraybuffer-base64#60 Differential Revision: https://phabricator.services.mozilla.com/D216279
ErichDonGubler
pushed a commit
to erichdongubler-mozilla/firefox
that referenced
this pull request
Jul 15, 2024
…ype.toBase64. r=spidermonkey-reviewers,dminor Changes from: tc39/proposal-arraybuffer-base64#60 Differential Revision: https://phabricator.services.mozilla.com/D216279
This was referenced Aug 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #59.