Editorial: Changing 'SetViewValue' to use 'ToNumber' instead of 'ToInteger' #1708
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devsnek
approved these changes
Sep 30, 2019
caiolima
referenced
this pull request
Sep 30, 2019
This PR includes changes over current ECMA262 spec text to include a new primitive type called `BigInt`. This includes all changes necessary to integrate this new primitive in the language. It also includes changes on TypedArray, introducing `BigInt64Array` and `BigUint64Array` Changes during PR review: - Make NumberToBigInt(...) a sub-clause of BigInt(...) and put "Runtime Semantics:" in the header, otherwise it looks too much like a built-in function. (Analogous to Function() and CreateDynamicFunction()) - Rewrite the characteristics of the BigInt prototype object as a bulleted list. - Change 9x "of BigInt type" to "of type BigInt". Also, 1x "of BigInt" to "of type BigInt". - In the BigInt:: ops, change a few '0' to '*0n*'. - For some BigInt:: ops, change the preamble to a complete sentence - Rename "BitwiseOp" as "BigIntBitwiseOp" for symmetry with NumberBitwiseOp. Also, add an 'aoid' attribute to the clause. - Replace "ToString Applied to the BigInt Type" with "BigIntToString" - Rename 'NumericLiteralBase' to 'NonDecimalIntegerLiteral'. It more clearly expresses what it is, and it fits nicely with 'DecimalIntegerLiteral'. - Put 'thisBigIntValue' in a <dfn> element. - Mention '_littleEndian_' in preambles for setBigInt64, setBigUint64 - Tweak pseudocode in Atomics.compareExchange - Reference new productions from Annex A. - Reproduce changes to 'NumericLiteral' in Annex B. - Replace <a> element with <emu-xref> - In "Numeric Type Operations" table, split "Value and Purpose" into 3 columns - Add ::toString() as a numeric type operation. - In BigInt::toString, invoke BigInt::toString directly, rather than via ToString. - Changing the grammar for BigInt literals to disallow them for Annex-B non-octal digits (tc39/proposal-bigint#208) - Relocate new property-clauses (Specifically, properties of DataView.prototype and the BigInt constructor.) - Move some new abstract op clauses. - Delete NumberToString: you have Number::toString; ditto BigIntToString and BigInt::toString. - In the "Type Conversion" clause, rather than simply putting all the new abstract operations at the end, move them to more logical locations. - Change "TypedArrayType" to "ElementType". "TypedArrayType" (and "TypedArray type") suggests one of the TypedArray types, where we're really talking about one of the TypedArray *element* types. - Add 'oldids' attributes - Reference DecimalBigIntegerLiteral from Annex A - Use NonDecimalIntegerLiteral in StrNumericLiteral Co-authored-by: Caio Lima <ticaiolima@gmail.com> Co-authored-by: Michael Dyck <jmdyck@ibiblio.org> Co-authored-by: Michael[tm] Smith <mike@w3.org>
ljharb
added
normative change
ljharb
approved these changes
Sep 30, 2019
ljharb
force-pushed
the
set-view-value-wrong
branch
from
66de7f6 to
a09c766
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #1515 changed this step to
ToIntegerwrongly. We need to change it back toToNumber.