Generate ArrayVecCopy without using patch #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
bluss
force-pushed
the
pr_arrayvec_copy_edit
branch
3 times, most recently
from
c941427 to
9c16e31
Compare
Invent this little hack, insert directives like this in ArrayVec: ```rust // DIRECTIVE ArrayVecCopy #[cfg(not_in_arrayvec_copy)] ``` And replace them as follows in ArrayVecCopy: ```rust #[cfg(not_in_arrayvec_copy)] ```
bluss
force-pushed
the
pr_arrayvec_copy_edit
branch
from
9c16e31 to
028b3e6
Compare
It's a type nested in a function, does not need renaming.
tbu-
approved these changes
Oct 21, 2024
Owner
tbu-
left a comment
tbu-
left a comment
There was a problem hiding this comment.
Thanks, that's a lot less brittle than the patch. :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Invent this little hack, insert directives like this in ArrayVec:
// DIRECTIVE ArrayVecCopy #[cfg(not_in_arrayvec_copy)]And replace them as follows in ArrayVecCopy:
#[cfg(not_in_arrayvec_copy)]