fix binary reader

Author: tbhaxor

BinaryFile/main.cpp

@@ -26,9 +26,12 @@ int main(int argc, char **argv) {
   ifile->open("student.dat", std::ios::binary);
   if (ifile->is_open()) {
     Student *s = new Student();
+
+    // safely read file from the
+    ifile->read(reinterpret_cast<char *>(s), sizeof(Student));
     while (!ifile->eof()) {
-      ifile->read(reinterpret_cast<char *>(s), sizeof(Student));
       std::cout << s->whoami() << std::endl;
+      ifile->read(reinterpret_cast<char *>(s), sizeof(Student));
     }
   } else {
     std::cerr << "Unable to open file\n";

BinaryFile/student.cpp

@@ -1,13 +1,22 @@
 #include "student.hpp"
+#include <cstring>
 #include <sstream>
 #include <string>
 
 void Student::setAge(int age) { this->age = age; }
 void Student::setAge(short age) { this->age = age; }
 void Student::setAge(unsigned short age) { this->age = age; }
 
-void Student::setName(std::string &name) { this->name = name; }
-void Student::setName(const char *name) { this->name = std::string(name); }
+void Student::setName(std::string &name) {
+  if (name.length() < 50) {
+    std::strcpy(this->name, name.c_str());
+  }
+}
+void Student::setName(const char *name) {
+  if (std::strlen(name) < 50) {
+    std::strcpy(this->name, name);
+  }
+}
 
 std::string Student::whoami() const {
   std::stringstream s;

BinaryFile/student.hpp

@@ -2,7 +2,7 @@
 
 class Student {
 private:
-  std::string name;
+  char name[50];
   unsigned short age;
 
 public: