Skip to content

Commit 9f6c331

Browse files
committed
Merge pull request google#453 from rjnagal/docker
Add error checks for netlink read.
2 parents 2a83a51 + efa8890 commit 9f6c331

File tree

2 files changed

+8
-2
lines changed

2 files changed

+8
-2
lines changed

utils/cpuload/conn.go

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -85,7 +85,10 @@ func (self *Connection) WriteMessage(msg syscall.NetlinkMessage) error {
8585
}
8686

8787
func (self *Connection) ReadMessage() (msg syscall.NetlinkMessage, err error) {
88-
binary.Read(self.rbuf, binary.LittleEndian, &msg.Header)
88+
err = binary.Read(self.rbuf, binary.LittleEndian, &msg.Header)
89+
if err != nil {
90+
return msg, err
91+
}
8992
msg.Data = make([]byte, msg.Header.Len-syscall.NLMSG_HDRLEN)
9093
_, err = self.rbuf.Read(msg.Data)
9194
return msg, err

utils/cpuload/netlink.go

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -76,7 +76,10 @@ func getFamilyId(conn *Connection) (uint16, error) {
7676
msg := prepareFamilyMessage()
7777
conn.WriteMessage(msg.toRawMsg())
7878

79-
resp, _ := conn.ReadMessage()
79+
resp, err := conn.ReadMessage()
80+
if err != nil {
81+
return 0, err
82+
}
8083
id, err := parseFamilyResp(resp)
8184
if err != nil {
8285
return 0, err

0 commit comments

Comments
 (0)