support for self-hosting gitlab-ce version (path unusing `-` dash)

[norimsu]

Hi, I'm happy to find this plug-in.

But there is some problem with using it.

I use self-hosting gitlab-ce.

The link requested by "/~/blob/..." does not work.

The other addresses work well except for "/~".

http://some-gitlab.com/some-group/some-project/~/blob/some-file.code   # doesn't work - 404
http://some-gitlab.com/some-group/some-project/blob/some-file.code     # work

The GitLab-CE version I use is '12.3.4 (f33961a395)'

What do you think about adding this content as an option?

[tavyandy97]

span-tree/content/src/scripts/components/TreeItem/TreeItem.jsx

Lines 35 to 37 in a3fa18e

	window.location.href = `${window.location.origin}/${
	URLDetails.dirFormatted
	}/-/blob/${URLDetails.branchName}/${path.join("/")}`;

None of the redirections in SpanTree involve the use of a ~(tilde).

1. http://some-gitlab.com/some-group/some-project/~/blob/some-file.code    # doesn't work - 404
2. http://some-gitlab.com/some-group/some-project/-/blob/some-file.code    # works
3. http://some-gitlab.com/some-group/some-project/blob/some-file.code      # works

Can you tell me when you click on a file in SpanTree, which link appears from the above?
Just for reference SpanTree uses 2 for redirection.

[norimsu]

oh, it's mistake

- not ~

for GitLab-CE 12.3.4 (f33961a395)

2. http://some-gitlab.com/some-group/some-project/-/blob/some-branch/some-file.code    # does not work - 404
3. http://some-gitlab.com/some-group/some-project/blob/some-branch/some-file.code      # works
4. http://some-gitlab.com/some-group/some-project/tree/some-branch/some-file.code      # works

[tavyandy97]

This is an issue that exists on GitLab (versions < 13).
Thanks for clarifying @norimsu . We have started working on a compatibility mode. It will be released within a week.

[lifesign]

same problem here, i installed from Chrome Web Store which version is 0.0.2.3, when will upgrade the store version

[tavyandy97]

Hey @norimsu and @lifesign

A compatibility mode has been added for the same. This will be updated in v0.0.2.5. It has been submitted for review on the Chrome Webstore(Should be approved within a day). Will be submitted for Mozilla Firefox soon.

[lifesign]

it works 👍 thx

[tavyandy97]

@lifesign, @norimsu
The extension has been updated on the Chrome Webstore to v0.0.2.5. It will updated on Mozilla Firefox soon. I am closing this issue for now.

[norimsu]

thx. 👍👍👍👍👍👍