fix(macos): Fix color mappings in window.rs (#1138)

Co-authored-by: FabianLars <github@fabianlars.de>

Author: aspcartman

.changes/fix-macos-bg-color.md

@@ -0,0 +1,5 @@
+---
+tao: patch
+---
+
+On macOS, fixed an issue that caused the window background color to be applied incorrectly (typically black).

examples/timer.rs

@@ -2,8 +2,7 @@
 // Copyright 2021-2023 Tauri Programme within The Commons Conservancy
 // SPDX-License-Identifier: Apache-2.0
 
-use std::time::Duration;
-use std::time::Instant;
+use std::time::{Duration, Instant};
 
 use tao::{
   event::{Event, StartCause, WindowEvent},

src/event_loop.rs

@@ -13,8 +13,7 @@
 //! [create_proxy]: crate::event_loop::EventLoop::create_proxy
 //! [event_loop_proxy]: crate::event_loop::EventLoopProxy
 //! [send_event]: crate::event_loop::EventLoopProxy::send_event
-use std::time::Instant;
-use std::{error, fmt, marker::PhantomData, ops::Deref};
+use std::{error, fmt, marker::PhantomData, ops::Deref, time::Instant};
 
 use crate::{
   dpi::PhysicalPosition,

src/platform_impl/android/ndk_glue.rs

@@ -47,6 +47,7 @@ pub static PACKAGE: OnceCell<&str> = OnceCell::new();
 ///       - `private external fun focus(focus: Boolean)`
 /// 4. a one time setup function that will be ran once after tao has created its event loop in the `create` function above.
 /// 5. the main entry point of your android application.
+#[rustfmt::skip]
 #[macro_export]
 macro_rules! android_binding {
   ($domain:ident, $package:ident, $activity:ident, $setup:path, $main:ident) => {

src/platform_impl/macos/window.rs

@@ -550,7 +550,12 @@ impl UnownedWindow {
         let color = win_attribs
           .background_color
           .map(|(r, g, b, a)| {
-            NSColor::colorWithRed_green_blue_alpha(r as f64, g as f64, b as f64, a as f64 / 255.0)
+            NSColor::colorWithRed_green_blue_alpha(
+              r as f64 / 255.0,
+              g as f64 / 255.0,
+              b as f64 / 255.0,
+              a as f64 / 255.0,
+            )
           })
           .unwrap_or_else(|| NSColor::clearColor());
         ns_window.setBackgroundColor(Some(&color));
@@ -906,9 +911,9 @@ impl UnownedWindow {
       let color = color
         .map(|(r, g, b, a)| {
           Some(NSColor::colorWithRed_green_blue_alpha(
-            r as f64,
-            g as f64,
-            b as f64,
+            r as f64 / 255.0,
+            g as f64 / 255.0,
+            b as f64 / 255.0,
             a as f64 / 255.0,
           ))
         })