Skip to content

Replaced string with bytes in BrokerMessage #89

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 7, 2023
Merged

Conversation

s3rius
Copy link
Member

@s3rius s3rius commented Apr 2, 2023

bytes are more reliable than string. It would be easier to transfer objects which are not compatible with utf-8 using bytes.

Signed-off-by: Pavel Kirilin <win10@list.ru>
@codecov-commenter
Copy link

Codecov Report

Merging #89 (d61275a) into develop (8cac3a6) will not change coverage.
The diff coverage is 100.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@           Coverage Diff            @@
##           develop      #89   +/-   ##
========================================
  Coverage    61.94%   61.94%           
========================================
  Files           37       37           
  Lines          938      938           
========================================
  Hits           581      581           
  Misses         357      357           
Impacted Files Coverage Δ
taskiq/formatters/json_formatter.py 100.00% <ø> (ø)
taskiq/message.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@booqoffsky booqoffsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

incredible

@s3rius s3rius added this to the 1.0.0 milestone Apr 5, 2023
@s3rius s3rius merged commit 3ada714 into develop Apr 7, 2023
@s3rius s3rius deleted the feature/msg-bytes branch April 7, 2023 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants