Optimize mode filtering

Extract a separate function to allow compilation instead of slow
evaluation.  This optimization helps when scrolling through large
documents, where previously the minions mode line eval appeared
in the profile for redisplay.

The bottleneck is `pcase-lambda', which performs horribly when not
compiled.  Because the whole file might not be compiled drop using
it altogether.  Also use `cl-filter-if-not' instead of `seq-filter',
for an additional, though tiny speedup, and also because it allows
dropping a dependency.

Author: minad

minions.el

@@ -41,7 +41,6 @@
 ;;; Code:
 
 (require 'cl-lib)
-(require 'seq)
 
 (eval-when-compile
   (require 'subr-x))
@@ -154,9 +153,7 @@ mouse-3: Toggle minor modes"
                       'mouse-face 'mode-line-highlight
                       'local-map (make-mode-line-mouse-map
                                   'mouse-2 #'mode-line-widen))
-          `(:propertize ("" (:eval (seq-filter (pcase-lambda (`(,mode))
-                                                 (memq mode minions-direct))
-                                               minor-mode-alist)))
+          `(:propertize ("" (:eval (minions--modes-direct)))
                         mouse-face mode-line-highlight
                         help-echo "Minor mode
 mouse-1: Display minor mode menu
@@ -215,6 +212,11 @@ Otherwise the entry can only be used to toggle the mode."
         (popup-menu map)
       (quit nil))))
 
+(defun minions--modes-direct ()
+  (cl-remove-if-not (lambda (mode)
+                      (memq (car mode) minions-direct))
+                    minor-mode-alist))
+
 (defun minions--modes ()
   (let (local global)
     (dolist (mode (cl-set-difference