From 3c6bb806ae21bbd800b4e25844b456db4e867c4c Mon Sep 17 00:00:00 2001
From: Tarsbir Singh <tarsbirsingh@gmail.com>
Date: Mon, 14 May 2018 21:36:04 +0530
Subject: [PATCH] Remove Hardcoding from Xml file

---
 app/src/main/res/layout/activity_main.xml | 41 ++++++++++++-----------
 app/src/main/res/values/colors.xml        |  2 ++
 2 files changed, 23 insertions(+), 20 deletions(-)

diff --git a/app/src/main/res/layout/activity_main.xml b/app/src/main/res/layout/activity_main.xml
index c63a580..4ea79c5 100644
--- a/app/src/main/res/layout/activity_main.xml
+++ b/app/src/main/res/layout/activity_main.xml
@@ -30,9 +30,9 @@
             android:inputType="textCapWords"/>
         <View
             android:layout_width="fill_parent"
-            android:layout_height="2dp"
+            android:layout_height="@dimen/two"
             android:layout_marginTop="@dimen/oneFour"
-            android:background="#c0c0c0"/>
+            android:background="@color/white"/>
         <TextView
             android:layout_width="wrap_content"
             android:layout_height="wrap_content"
@@ -85,9 +85,9 @@
         </RadioGroup>
         <View
             android:layout_width="fill_parent"
-            android:layout_height="2dp"
+            android:layout_height="@dimen/two"
             android:layout_marginTop="@dimen/oneFour"
-            android:background="#c0c0c0"/>
+            android:background="@color/white"/>
         <!--Second Question-->
         <TextView
             android:layout_width="wrap_content"
@@ -140,9 +140,9 @@
         </RadioGroup>
         <View
             android:layout_width="fill_parent"
-            android:layout_height="2dp"
+            android:layout_height="@dimen/two"
             android:layout_marginTop="@dimen/oneFour"
-            android:background="#c0c0c0"/>
+            android:background="@color/white"/>
         <!--Third Question-->
         <TextView
             android:layout_width="wrap_content"
@@ -196,9 +196,9 @@
         </RadioGroup>
         <View
             android:layout_width="fill_parent"
-            android:layout_height="2dp"
+            android:layout_height="@dimen/two"
             android:layout_marginTop="@dimen/oneFour"
-            android:background="#c0c0c0"/>
+            android:background="@color/white"/>
         <!--Fourth Question-->
         <TextView
             android:layout_width="wrap_content"
@@ -251,9 +251,9 @@
         </RadioGroup>
         <View
             android:layout_width="fill_parent"
-            android:layout_height="2dp"
+            android:layout_height="@dimen/two"
             android:layout_marginTop="@dimen/oneFour"
-            android:background="#c0c0c0"/>
+            android:background="@color/white"/>
         <!--Fifth Question-->
         <TextView
             android:layout_width="wrap_content"
@@ -306,9 +306,10 @@
         </RadioGroup>
         <View
             android:layout_width="fill_parent"
-            android:layout_height="2dp"
+            android:layout_height="@dimen/two"
             android:layout_marginTop="@dimen/oneFour"
-            android:background="#c0c0c0"/>
+            android:background="@color/white"/>
+        <!--Sixth Question-->
         <TextView
             android:layout_width="wrap_content"
             android:layout_height="wrap_content"
@@ -364,9 +365,9 @@
         </LinearLayout>
         <View
             android:layout_width="fill_parent"
-            android:layout_height="2dp"
+            android:layout_height="@dimen/two"
             android:layout_marginTop="@dimen/oneFour"
-            android:background="#c0c0c0"/>
+            android:background="@color/white"/>
         <!--Seventh Question-->
         <TextView
             android:layout_width="wrap_content"
@@ -419,9 +420,9 @@
         </RadioGroup>
         <View
             android:layout_width="fill_parent"
-            android:layout_height="2dp"
+            android:layout_height="@dimen/two"
             android:layout_marginTop="@dimen/oneFour"
-            android:background="#c0c0c0"/>
+            android:background="@color/white"/>
         <!--Eight Question-->
         <TextView
             android:layout_width="wrap_content"
@@ -474,9 +475,9 @@
         </RadioGroup>
         <View
             android:layout_width="fill_parent"
-            android:layout_height="2dp"
+            android:layout_height="@dimen/two"
             android:layout_marginTop="@dimen/oneFour"
-            android:background="#c0c0c0"/>
+            android:background="@color/white"/>
         <!--NIne Question-->
         <TextView
             android:layout_width="wrap_content"
@@ -498,9 +499,9 @@
             android:inputType="textCapWords"/>
         <View
             android:layout_width="fill_parent"
-            android:layout_height="2dp"
+            android:layout_height="@dimen/two"
             android:layout_marginTop="@dimen/oneFour"
-            android:background="#c0c0c0"/>
+            android:background="@color/white"/>
         <!--10 Question-->
         <TextView
             android:layout_width="wrap_content"
diff --git a/app/src/main/res/values/colors.xml b/app/src/main/res/values/colors.xml
index 4e3aa69..8acc617 100644
--- a/app/src/main/res/values/colors.xml
+++ b/app/src/main/res/values/colors.xml
@@ -4,4 +4,6 @@
     <color name="colorPrimaryDark">#303F9F</color>
     <color name="colorAccent">#FF4081</color>
     <color name="ol">#FF4003</color>
+    <color name="white">#c0c0c0</color>
+
 </resources>