From f755fc4ef21864d3dd2ed5745089bdc260982302 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Micha=C3=ABl=20Zasso?= Date: Fri, 30 Apr 2021 12:56:47 +0200 Subject: [PATCH] deps: V8: cherry-pick 00245033cf75 Original commit message: M86-LTS: [compiler] Fix off-by-one error in kAdditiveSafeInteger (cherry picked from commit 798fbcb0a3e5a292fb775c37c19d9fe73bbac17c) No-Try: true No-Presubmit: true No-Tree-Checks: true Bug: chromium:1198705 Change-Id: I6b3ad82754e1ca72701ce57f16c4f085f8c87f77 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2835705 Auto-Submit: Georg Neis Commit-Queue: Nico Hartmann Reviewed-by: Nico Hartmann Cr-Original-Commit-Position: refs/heads/master@{#74033} Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2850708 Commit-Queue: Artem Sumaneev Reviewed-by: Victor-Gabriel Savu Cr-Commit-Position: refs/branch-heads/8.6@{#87} Cr-Branched-From: a64aed2333abf49e494d2a5ce24bbd14fff19f60-refs/heads/8.6.395@{#1} Cr-Branched-From: a626bc036236c9bf92ac7b87dc40c9e538b087e3-refs/heads/master@{#69472} Refs: https://github.com/v8/v8/commit/00245033cf756f86cef7e830661810777aaf3476 PR-URL: https://github.com/nodejs/node/pull/38481 Reviewed-By: Richard Lau --- common.gypi | 2 +- deps/v8/src/compiler/type-cache.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/common.gypi b/common.gypi index 2a849923d3b936..aa4279d93ca35c 100644 --- a/common.gypi +++ b/common.gypi @@ -36,7 +36,7 @@ # Reset this number to 0 on major V8 upgrades. # Increment by one for each non-official patch applied to deps/v8. - 'v8_embedder_string': '-node.62', + 'v8_embedder_string': '-node.63', ##### V8 defaults for Node.js ##### diff --git a/deps/v8/src/compiler/type-cache.h b/deps/v8/src/compiler/type-cache.h index b71ea8455d544d..54e725c64f7e35 100644 --- a/deps/v8/src/compiler/type-cache.h +++ b/deps/v8/src/compiler/type-cache.h @@ -80,7 +80,7 @@ class V8_EXPORT_PRIVATE TypeCache final { Type::Union(kPositiveIntegerOrMinusZero, Type::NaN(), zone()); Type const kAdditiveSafeInteger = - CreateRange(-4503599627370496.0, 4503599627370496.0); + CreateRange(-4503599627370495.0, 4503599627370495.0); Type const kSafeInteger = CreateRange(-kMaxSafeInteger, kMaxSafeInteger); Type const kAdditiveSafeIntegerOrMinusZero = Type::Union(kAdditiveSafeInteger, Type::MinusZero(), zone());