Skip to content

Commit 40d0e2b

Browse files
committed
deps: disable V8 concurrent sparkplug compilation
It introduces process hangs on some platforms because Node.js doesn't tear down V8 correctly. Disable it while we work on a solution. Refs: nodejs#47297 Refs: https://bugs.chromium.org/p/v8/issues/detail?id=13902 PR-URL: nodejs#47450 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
1 parent 163b143 commit 40d0e2b

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

common.gypi

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@
3838

3939
# Reset this number to 0 on major V8 upgrades.
4040
# Increment by one for each non-official patch applied to deps/v8.
41-
'v8_embedder_string': '-node.1',
41+
'v8_embedder_string': '-node.2',
4242

4343
##### V8 defaults for Node.js #####
4444

deps/v8/src/flags/flag-definitions.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1070,7 +1070,7 @@ DEFINE_BOOL(baseline_batch_compilation, true, "batch compile Sparkplug code")
10701070
DEFINE_BOOL_READONLY(concurrent_sparkplug, false,
10711071
"compile Sparkplug code in a background thread")
10721072
#else
1073-
DEFINE_BOOL(concurrent_sparkplug, ENABLE_SPARKPLUG_BY_DEFAULT,
1073+
DEFINE_BOOL(concurrent_sparkplug, false,
10741074
"compile Sparkplug code in a background thread")
10751075
DEFINE_WEAK_IMPLICATION(future, concurrent_sparkplug)
10761076
DEFINE_NEG_IMPLICATION(predictable, concurrent_sparkplug)

0 commit comments

Comments
 (0)