crud: store the cursor's after_tuple explicitly as a Lua table
#387
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In scope of tarantool/tarantool#8147, a new context-dependent extension for box tuples, `MP_TUPLE`, is introduced. If the merger's buffer source is used, raw MsgPack is received, which does not allow for passing the context required for decoding `MP_TUPLE`. At the same time, all box tuples are now encoded as `MP_TUPLE` by default. If the merger's tuple chunk can be decoded by manually skipping the extension header of `MP_TUPLE` and the tuple format of individual tuples, the cursor is decoded using the Lua `msgpack` library, which cannot handle `MP_TUPLE`s without a decoding context. The cursor's `after_tuple` field is a box tuple, so in order to overcome the limitation above, we need to explicitly convert it to a Lua table. Needed for tarantool/tarantool#8147
DifferentialOrange
approved these changes
Oct 16, 2023
Totktonada
approved these changes
Oct 16, 2023
Contributor
Totktonada
left a comment
Totktonada
left a comment
There was a problem hiding this comment.
No objections from my side.
DifferentialOrange
added a commit
that referenced
this pull request
Oct 16, 2023
Overview This release improves experience for VShard clusters users and Tarantool 3 users. It also introduces schema introspection API. New features * Space schema introspection API `crud.schema` (#380). Bugfixes * Return explicit error for `*_many` call with no tuples/objects (#377). * `crud.readview` resource cleanup on garbage collect (#379). * VShard storage user have not execution rights for internal functions (#366). * Compatibility with Tarantool 3.0 tuple objects (#387). Infrastructure * `deps.sh` installs the `vshard` instead of the `cartridge` by default (#364). You could to specify an environment variable `CARTIRDGE_VERSION` to install the `cartridge` and run tests cases with it. * `doc/playground.lua` does not work with Tarantool 3 (#371). * Tests with Tarantool 3 (#364). * Quickstart section in the README.md focuses on usage with `vshard` instead of `Cartridge` (#366).
Merged
DifferentialOrange
added a commit
that referenced
this pull request
Oct 16, 2023
Overview This release improves experience for VShard clusters users and Tarantool 3 users. It also introduces schema introspection API. New features * Space schema introspection API `crud.schema` (#380). Bugfixes * Return explicit error for `*_many` call with no tuples/objects (#377). * `crud.readview` resource cleanup on garbage collect (#379). * VShard storage user have not execution rights for internal functions (#366). * Compatibility with Tarantool 3.0 tuple objects (#387). Infrastructure * `deps.sh` installs the `vshard` instead of the `cartridge` by default (#364). You could to specify an environment variable `CARTIRDGE_VERSION` to install the `cartridge` and run tests cases with it. * `doc/playground.lua` does not work with Tarantool 3 (#371). * Tests with Tarantool 3 (#364). * Quickstart section in the README.md focuses on usage with `vshard` instead of `Cartridge` (#366).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In scope of tarantool/tarantool#8147, a new context-dependent extension for box tuples,
MP_TUPLE, is introduced. If the merger's buffer source is used, raw MsgPack is received, which does not allow for passing the context required for decodingMP_TUPLE.At the same time, all box tuples are now encoded as
MP_TUPLEby default. If the merger's tuple chunk can be decoded by manually skipping the extension header ofMP_TUPLEand the tuple format of individual tuples, the cursor is decoded using the Luamsgpacklibrary, which cannot handleMP_TUPLEs without a decoding context.The cursor's
after_tuplefield is a box tuple, so in order to overcome the limitation above, we need to explicitly convert it to a Lua table.I didn't forget about
Needed for tarantool/tarantool#8147