Update French.xml#768
Conversation
Hello I'm submitting this final update after correcting a few minor French errors and typos. Please note that the translation of the last tables in the developer menu is as good as I could be, and Thanner is still waiting to answer my question about the missing lines in Master.xml. Of course, if I've made any irrelevant suggestions, I'll revise my work. Best regards, Denis Signed-off-by: Curious Insatiable <113294705+Need74@users.noreply.github.com>
|
Hello @Need74. Thank you for your ongoing work on PhotoDemon translations! This is a very large list of changes. It is difficult to accurately review huge updates like this. Perhaps in the future we can use small batches of related changes, to make it much easier to review and discuss? At first glance, you need to remove the English phrases you have manually added. These phrases are omitted intentionally, and they will be forcibly stripped by PhotoDemon's translation file manager. (The same goes for manually added XML comments - these are automatically stripped from translation files, and will not persist between updates.) These phrases come from developer-only tools found in the "Tools > Developer" menu, a menu that is only available in nightly builds. These tools are not useful to anyone but me, and they only exist because I am committed to 100% transparency for all PhotoDemon code. It is a waste of time and resources for translators to translate them, which is why they aren't already included in PhotoDemon's translation files. In the future, I think it would be best to ask questions about translation file contents before assuming that they are full of mistakes. There is often (not always, but often) a reason that these files look the way they do! Please remove those additional phrases, and then I can tag in mizka76 and start reviewing some of the other changes here. Thank you! |
Removal of the translation of explicit terms in the developer section. I hadn't realized that these elements were only present in the "nightly" builds. Signed-off-by: Curious Insatiable <113294705+Need74@users.noreply.github.com>
|
A less ambitious version that includes the essentials. I will post an update later covering minor but still important aspects of the program's usability. Regards Signed-off-by: Curious Insatiable <113294705+Need74@users.noreply.github.com>
A less ambitious version that includes the essentials. I will post an update later covering minor but still important aspects of the program's usability. Regards Signed-off-by: Curious Insatiable <113294705+Need74@users.noreply.github.com>
A less ambitious version that includes the essentials. I will post an update later covering minor but still important aspects of the program's usability. Regards Signed-off-by: Curious Insatiable <113294705+Need74@users.noreply.github.com>
Hello @tannerhelland Indeed, I hadn't realized that these elements were only present in the "nightly" builds. So I've removed the translation of the explicit terms from the developer section. I'm obviously leaving mizka76 in charge of this translation so he can decide for himself on the validity of my changes, since for the most part, it's just isolated single characters in sentences, such as capital letters, non-breaking spaces, or other typos (being French like me, I think he should be able to validate the changes within a reasonable time frame). However, I've noted your suggestion and I've split the changes into two successive pull requests to make tracking easier for everyone. I'm quite a perfectionist by nature, and I admit that, like many people, I'm bothered by minor inconsistencies between menus and/or dialog boxes. In any case, my suggestions are just that—suggestions—and I commend once again the colossal amount of work done by the developers, which clearly brings PhotoDemon to a level very close to PaintShop, the industry standard recognized by professionals. Best regards, |
|
Thank you for the update and clarification, @Need74 ! I appreciate the changes you have made. My next question about this set of changes: can you help me better understand the issue with space characters preceding a colon character? PhotoDemon's language file currently strips some trailing punctuation characters (like "..." and ":") from translations. This was a design choice made many years ago at the suggestion of my first language file contributor, to avoid multiple translations for e.g.
red: The thought (at the time) was that the size of the translation file would be significantly larger if every variation of every phrase's punctuation was included. So PhotoDemon strips these trailing punctuation characters when generating language files, and adds them back in at run-time. (I have been trying to reduce usage of colons in general, but I have not done a "comprehensive" purge across the full project yet.) In English there is no non-breaking space between text and a trailing colon (or an ellipsis), but if there is supposed to be a non-breaking space in French, I can easily add that feature in code. This is my preferred solution as it guarantees consistency, vs changes in the language file where it is very easy for small inconsistencies to creep in over time. Simply let me know the grammatical rule and how it is to be applied in French, and I will get started on a fix in the source code. Thank you! |
Hello
I'm submitting this final update after correcting a few minor French errors and typos.
Please note that the translation of the last tables in the developer menu is as good as I could be, and Thanner is still waiting to answer my question about the missing lines in Master.xml.
Of course, if I've made any irrelevant suggestions, I'll revise my work.
Best regards,
Denis