Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

False failure if asterisk is inside string #63

Closed
yajo opened this issue Nov 25, 2020 · 4 comments
Closed

False failure if asterisk is inside string #63

yajo opened this issue Nov 25, 2020 · 4 comments
Labels
bug Something isn't working schema JSON-schema related issues

Comments

@yajo
Copy link

yajo commented Nov 25, 2020

Issue Type: Bug

This code is good, but it appears as bad:
imagen

Extension version: 0.9.3
VS Code version: Code 1.51.1 (e5a624b788d92b8d34d1392e4c4d9789406efe8f, 2020-11-10T23:31:29.624Z)
OS version: Linux x64 5.9.8-200.fc33.x86_64

System Info
Item Value
CPUs Intel(R) Core(TM) i7-9750H CPU @ 2.60GHz (12 x 4000)
GPU Status 2d_canvas: enabled
flash_3d: enabled
flash_stage3d: enabled
flash_stage3d_baseline: enabled
gpu_compositing: enabled
multiple_raster_threads: enabled_on
oop_rasterization: disabled_off
opengl: enabled_on
protected_video_decode: unavailable_off
rasterization: disabled_software
skia_renderer: enabled_on
video_decode: unavailable_off
vulkan: disabled_off
webgl: enabled
webgl2: enabled
Load (avg) 1, 1, 2
Memory (System) 15.48GB (0.49GB free)
Process Argv --no-sandbox --unity-launch --crash-reporter-id 1b07b1f6-f187-42fc-aa9e-516fd1a4c83e
Screen Reader no
VM 0%
DESKTOP_SESSION gnome
XDG_CURRENT_DESKTOP GNOME
XDG_SESSION_DESKTOP gnome
XDG_SESSION_TYPE x11
@tamasfe tamasfe added bug Something isn't working schema JSON-schema related issues labels Nov 25, 2020
@tamasfe
Copy link
Owner

tamasfe commented Nov 25, 2020

The authors value is invalid according to the docs.

@yajo
Copy link
Author

yajo commented Nov 25, 2020

Oh sorry, I was thinking that this only was basic TOML linter, not Poetry-specific.

@yajo yajo closed this as completed Nov 25, 2020
@yajo
Copy link
Author

yajo commented Nov 25, 2020

Oh but line 16 is still a false failure, right?

@yajo yajo reopened this Nov 25, 2020
@tamasfe
Copy link
Owner

tamasfe commented Nov 25, 2020

Oh but line 16 is still a false failure, right?

Yep, the version regex has to be fixed in the poetry schema, I will get to it at some point.

However it might be after #58 so that schema changes don't require a new version of the extension.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working schema JSON-schema related issues
Projects
None yet
Development

No branches or pull requests

2 participants