Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for JDK 17? #28

Open
sureshg opened this issue Oct 11, 2022 · 4 comments
Open

Support for JDK 17? #28

sureshg opened this issue Oct 11, 2022 · 4 comments

Comments

@sureshg
Copy link

sureshg commented Oct 11, 2022

I am not sure whether this plugin is still maintained. If so, any plans to update the GJF version to latest which has support for the latest JDK versions. Thanks for making this plugin and allow us to make maxLineLength configurable.

@dudeisbrendan03
Copy link

> & mvn process-sources
[INFO] Scanning for projects...
[INFO] 
[INFO] ------------------< com.group31.editor:pixel-editor >-------------------
[INFO] Building pixel-editor v0.1-CANARY
[INFO] --------------------------------[ jar ]---------------------------------
[INFO] 
[INFO] --- googleformatter-maven-plugin:1.7.3:format (reformat-sources) @ pixel-editor ---
[INFO] Found 37 uncompiled/modified files in C:\Users\Terri\source\repos\scc210-2223-grp-31\src\main\java to reformat.
[INFO] Found 1 uncompiled/modified files in C:\Users\Terri\source\repos\scc210-2223-grp-31\src\test\java to reformat.
[INFO] ------------------------------------------------------------------------
[INFO] Finished at: 2022-12-10T10:21:45Z
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal com.theoryinpractise:googleformatter-maven-plugin:1.7.3:format (reformat-sources) on project pixel-editor: 38:18: error: : expected -> [Help 1]
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException

> java --version
openjdk 17.0.5 2022-10-18
OpenJDK Runtime Environment Temurin-17.0.5+8 (build 17.0.5+8)
OpenJDK 64-Bit Server VM Temurin-17.0.5+8 (build 17.0.5+8, mixed mode)

>

@dudeisbrendan03
Copy link

Appears to work with jdk17, getting a weird error with no clue how to fix it so I can't integrate it into Ci yet, but it doesn't look like anything too bad

@tbw777
Copy link

tbw777 commented Feb 8, 2023

@dudeisbrendan03
try to check: mvn -X option

@talios
Copy link
Owner

talios commented Feb 9, 2023

The only issue with updating it to the latest versions is we have to remove support for line length customization.

I'm not still not using >Java 8 (politics, infrastructure issues) so havn't updated this mojo, but on the project I am using 17+ - I'm now using the spotless plugin with either the google formatter, or the palantir formatter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants