refactoring

Author: takaakit

README.md

@@ -57,7 +57,7 @@ export class FileElement extends FileSystemElement {
     // Print this element with the "upperPath".
     print(upperPath) {
         // ˅
-        console.log(upperPath + '/' + this.toString());
+        console.log(`${upperPath}/${this.toString()}`);
         // ˄
     }
 

behavioral-patterns/chain-of-responsibility/supporter.mjs

@@ -28,7 +28,7 @@ export class Supporter {
         if (this.canHandle(trouble)) {
             this.supported(trouble);
         }
-        else if (this.next != null) {
+        else if (this.next !== null) {
             this.next.support(trouble);
         }
         else {

behavioral-patterns/command/app-main.mjs

@@ -27,6 +27,7 @@ export class AppMain {
 
     constructor() {
         // ˅
+        this.isDragging = false;
         this.canvas = document.getElementById(`canvas`);
         this.undoButton = document.getElementById(`undoButton`)
         this.clearButton = document.getElementById(`clearButton`)
@@ -54,9 +55,9 @@ export class AppMain {
         if(this.isDragging){
             const paintingPosX = event.clientX - this.canvas.getBoundingClientRect().left;
             const paintingPosY = event.clientY - this.canvas.getBoundingClientRect().top ;
-            const paintingCommand = new PaintingCommand(this.paintingCanvas, paintingPosX, paintingPosY);
-            this.history.add(paintingCommand);
-            paintingCommand.execute();
+            const command = new PaintingCommand(this.paintingCanvas, paintingPosX, paintingPosY);
+            this.history.add(command);
+            command.execute();
         }
         // ˄
     }

behavioral-patterns/command/history-command.mjs

@@ -39,7 +39,7 @@ export class HistoryCommand extends Command {
     // Delete the last command
     undo() {
         // ˅
-        if (this.pastCommands.length != 0) {
+        if (this.pastCommands.length !== 0) {
             this.pastCommands.pop();
         }
         // ˄

behavioral-patterns/interpreter/command-list.mjs

@@ -23,7 +23,7 @@ export class CommandList extends Node {
     parse(context) {
         // ˅
         while (true) {
-            if (context.getToken() == null) {
+            if (context.getToken() === null) {
                 throw new Error(`Missing "end"`);
             }
             else if (context.getToken() === `end`) {

behavioral-patterns/visitor/directory-element.mjs

@@ -39,11 +39,11 @@ export class DirectoryElement extends FileSystemElement {
 
     get size() {
         // ˅
-        let value = 0;
+        let size = 0;
         for (let element of this.elements) {
-            value += element.size;
+            size += element.size;
         }
-        return value;
+        return size;
         // ˄
     }
 

creational-patterns/abstract-factory/main.mjs

@@ -17,23 +17,24 @@ const readline = rl.createInterface({
 });
 
 readline.question(``, (data) => {
-    let input = Number(data);
+    const input = Number(data);
     readline.close();
     if (isNaN(input)) {
         console.log(`Unexpected value.`);
         process.exit(1);
     }
 
     let factory = null;
-    if (input == 1) {
-        factory = new ListFactory();
-    }
-    else if (input == 2) {
-        factory = new TableFactory();
-    }
-    else {
-        console.log(`The value is not 1 or 2.`);
-        process.exit(1);
+    switch (input) {
+        case 1:
+            factory = new ListFactory();
+            break;
+        case 2:
+            factory = new TableFactory();
+            break;
+        default:
+            console.log(`The value is not 1 or 2.`);
+            process.exit(1);
     }
 
     const washingtonPost = factory.createLink(`The Washington Post`, `https://www.washingtonpost.com/`);

creational-patterns/builder/main.mjs

@@ -18,18 +18,18 @@ const readline = rl.createInterface({
 });
 
 readline.question(``, (data) => {
-    let input = data;
+    const input = data;
     readline.close();
 
-    if (input == `plain`) {
+    if (input === `plain`) {
         const plainTextBuilder = new PlainTextBuilder();
         const directory = new Director(plainTextBuilder);
         directory.build();
 
         const content = plainTextBuilder.getContent();
         console.log(content);
     }
-    else if (input == `html`) {
+    else if (input === `html`) {
         const htmlBuilder = new HTMLBuilder();
         const directory = new Director(htmlBuilder);
         directory.build();

structural-patterns/composite/directory-element.mjs

@@ -31,8 +31,8 @@ export class DirectoryElement extends FileSystemElement {
     get size() {
         // ˅
         let size = 0;
-        for (let i = 0; i < this.elements.length; i++) {
-            size += this.elements[i].size;
+        for (let element of this.elements) {
+            size += element.size;
         }
         return size;
         // ˄
@@ -42,8 +42,8 @@ export class DirectoryElement extends FileSystemElement {
     print(upperPath) {
         // ˅
         console.log(`${upperPath}/${this.toString()}`);
-        for (let i = 0; i < this.elements.length; i++) {
-            this.elements[i].print(`${upperPath}/${this.name}`);
+        for (let element of this.elements) {
+            element.print(`${upperPath}/${this.name}`);
         }
         // ˄
     }

structural-patterns/decorator/side-frame.mjs

@@ -17,7 +17,7 @@ export class SideFrame extends Frame {
         // ˅
         super(display);
 
-        if (frameChar.length != 1) {
+        if (frameChar.length !== 1) {
             console.log(`Only one character is allowed in a side frame.`);
             process.exit(1);
         }