refactor: delete class-validator for minimal boilerplate

Author: tak-bro

package-lock.json

@@ -29,7 +29,6 @@
     "@nestjs/typeorm": "^7.0.0",
     "aws-lambda": "^1.0.5",
     "aws-serverless-fastify": "^1.0.13",
-    "class-validator": "^0.11.1",
     "mysql": "^2.18.1",
     "reflect-metadata": "^0.1.13",
     "rimraf": "^3.0.2",

package.json

@@ -1,27 +1,20 @@
 import { Column, Entity, PrimaryGeneratedColumn, CreateDateColumn, UpdateDateColumn } from 'typeorm';
-import { IsDate, IsNumber, IsOptional, IsString } from 'class-validator';
 
 @Entity('Dummy')
 export class DummyEntity {
 
-    @IsString()
     @PrimaryGeneratedColumn('uuid')
     dummyId: string;
 
-    @IsString()
     @Column('varchar', { length: 10 })
     name: string;
 
-    @IsOptional()
-    @IsNumber()
     @Column('int', { unsigned: true, nullable: true })
     age?: number;
 
-    @IsDate()
     @CreateDateColumn({ type: 'timestamp' })
     createdAt: Date;
 
-    @IsDate()
     @UpdateDateColumn({ type: 'timestamp' })
     updatedAt: Date;
 

src/entities/dummy.entity.ts

@@ -1,15 +1,11 @@
 import { ApiProperty } from '@nestjs/swagger';
-import { IsString, IsNumber, IsOptional } from 'class-validator';
 
 export class CreateDummyDto {
 
     @ApiProperty()
-    @IsString()
     readonly name: string;
 
     @ApiProperty()
-    @IsOptional()
-    @IsNumber()
     readonly age?: number;
 
 }

src/modules/dummy/dto/create-dummy.dto.ts

@@ -1,21 +1,14 @@
-import { IsNumber, IsOptional, IsString } from 'class-validator';
 import { ApiProperty } from '@nestjs/swagger';
 
 export class DummyQueryDto {
 
     @ApiProperty()
-    @IsOptional()
-    @IsNumber()
     readonly page?: number;
 
     @ApiProperty()
-    @IsOptional()
-    @IsNumber()
     readonly limit?: number;
 
     @ApiProperty()
-    @IsOptional()
-    @IsString()
     readonly name?: string;
 
 }

src/modules/dummy/dto/dummy-query.dto.ts

@@ -1,29 +1,22 @@
-import { IsDate, IsNumber, IsOptional, IsString } from 'class-validator';
 import { ApiProperty } from '@nestjs/swagger';
 
 import { DummyEntity } from '@entities/dummy.entity';
 
 export class DummyDto {
 
     @ApiProperty()
-    @IsString()
     readonly dummyId: string;
 
     @ApiProperty()
-    @IsString()
     readonly name: string;
 
     @ApiProperty()
-    @IsOptional()
-    @IsNumber()
     readonly age?: number;
 
     @ApiProperty()
-    @IsDate()
     readonly createdAt: Date;
 
     @ApiProperty()
-    @IsDate()
     readonly updatedAt: Date;
 
     constructor(dummy: DummyEntity) {

src/modules/dummy/dto/dummy.dto.ts

@@ -1,16 +1,11 @@
 import { ApiProperty } from '@nestjs/swagger';
-import { IsString, IsNumber, IsOptional } from 'class-validator';
 
 export class UpdateDummyDto {
 
     @ApiProperty()
-    @IsOptional()
-    @IsString()
     readonly name?: string;
 
     @ApiProperty()
-    @IsOptional()
-    @IsNumber()
     readonly age?: number;
 
 }

src/modules/dummy/dto/update-dummy.dto.ts

@@ -21,18 +21,18 @@ export class DummyController {
     }
 
     @Get()
-    async getPlayerList(@Query() query: DummyQueryDto): Promise<Pagination<DummyDto>> {
+    async getDummyList(@Query() query: DummyQueryDto): Promise<Pagination<DummyDto>> {
         return await this.dummyService.getList(query);
     }
 
     @Get(':id')
-    async findPlayerById(@Param() params): Promise<DummyDto> {
+    async findDummyById(@Param() params): Promise<DummyDto> {
         return await this.dummyService.findById(params.id);
     }
 
     @Post()
-    async create(@Body() player: CreateDummyDto): Promise<DummyDto> {
-        return await this.dummyService.create(player);
+    async create(@Body() dummy: CreateDummyDto): Promise<DummyDto> {
+        return await this.dummyService.create(dummy);
     }
 
     @Put(':id')

src/modules/dummy/dummy.controller.ts

@@ -38,8 +38,8 @@ export class DummyService {
 
     async findById(dummyId: string): Promise<DummyDto> {
         try {
-            const player = await this.dummyRepository.findOne({ dummyId }).then(dummy => new DummyDto(dummy));
-            return new DummyDto(player);
+            const dummy = await this.dummyRepository.findOne(dummyId).then(dummy => new DummyDto(dummy));
+            return new DummyDto(dummy);
         } catch (err) {
             throw new Error(err);
         }