Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom class for gant-hint #146

Closed
PeterFour opened this issue Jun 30, 2014 · 1 comment
Closed

Custom class for gant-hint #146

PeterFour opened this issue Jun 30, 2014 · 1 comment

Comments

@PeterFour
Copy link

It would be great to also have an option in the values object to add a custom class for our gantt-hint. (By the way why does the values have to be an array because we can only put one object in it ?)

@usmonster
Copy link
Collaborator

@PeterFour, thanks for the suggestion -- this has actually been brought up previously in #98. I think I prefer the implementation there, which moves the hint markup inside the bar, thus allowing the custom class to be reused to style the hint as well. This avoids needing to add yet another class or changing the requirements or structure of the source data, though there are still minor issues (mentioned on that issue).

Also, the pull request no longer merges cleanly, so a new one would need to be made. Feel free to ping the PR author or make a new pull request in that style! Otherwise I will probably take a look at it after some higher-priority bugs are fixed. In the meantime, I will close this one, and you can track the issue by subscribing to #98.

As for your question about why values is an array in the source, it's because you actually add add many values/bars to the same row. (At this point it would no longer be a traditional Gantt chart, but it's a feature that's just there...)

Thanks again for bringing this up!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants