Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose scrollToTarget and document subclasses #125

Merged
merged 1 commit into from
Nov 8, 2017
Merged

Expose scrollToTarget and document subclasses #125

merged 1 commit into from
Nov 8, 2017

Conversation

taion
Copy link
Owner

@taion taion commented Nov 7, 2017

No description provided.

@taion
Copy link
Owner Author

taion commented Nov 8, 2017

cc @satazor, @vasco-santos

@satazor
Copy link

satazor commented Nov 8, 2017

@taion Looks good.

I would prefer the callback though, for two reasons:

  • Easier to use
  • Less surface for breaking changes

Anyway I understand and respect your decision.

@taion
Copy link
Owner Author

taion commented Nov 8, 2017

It is easier to use, but I think the surface area is a bit lower here, in the sense that we're just exposing overridable methods in a standard-ish way, such that can be extended for other applications, instead of adding a specific carveout for a single callback.

Thanks for your patience here. I'll release shortly.

@taion taion merged commit ad26288 into master Nov 8, 2017
@taion taion deleted the subclass branch November 8, 2017 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants