Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add variants for orientation media feature #6046

Merged
merged 2 commits into from
Nov 23, 2021
Merged

Add variants for orientation media feature #6046

merged 2 commits into from
Nov 23, 2021

Conversation

lukewarlow
Copy link
Contributor

@lukewarlow lukewarlow commented Nov 10, 2021 •
edited
Loading

This PR adds variants for the orientation media feature

orientation-portrait: for targeting portrait orientation.

orientation-landscape: for targeting landscape orientation.

@lukewarlow lukewarlow marked this pull request as ready for review November 10, 2021 23:23
@lukewarlow lukewarlow changed the title Add variants for orientation media feature Add variants for orientation media feature Nov 10, 2021
@adamwathan
Copy link
Member

Thanks! Renamed to just portrait and landscape but gonna sneak it in for v3.0 👍🏻

@adamwathan adamwathan merged commit a321e3c into tailwindlabs:master Nov 23, 2021
@dcastil dcastil mentioned this pull request Dec 10, 2021
Merged
45 tasks
@ben-rogerson ben-rogerson mentioned this pull request Dec 20, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lukewarlow @adamwathan