Ensure arbitrary values only support valid values #5293
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will ensure that the build doesn't fail all of a sudden. It turns out that CSS doesn't like all the "invalid" css you throw at it. For example, when you have this:
The issue here is that we forgot a space, however this crashes the build (even in watch mode) and you would have to restart the server to fix it. The reason for this is because the result of that line, results in something like this:
Obviously wrong, but if we minimize the issue, then this is also invalid syntax (Ref: https://twitter.com/adamwathan/status/1430481262016352260?s=20):
https://jsfiddle.net/op01ubz6/1/
It sort of makes sense, but the browser doesn't have a problem with this :
https://jsfiddle.net/op01ubz6/
This PR will ensure that the first line (
w-[200px]h-[100px]
) will not even be generated.