Improve extractor for arbitrary values with quotes #4817
Merged
+64
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4801.
This PR improves our default extractor regex to handle arbitrary values that are wrapped in quotes more precisely.
Previously, given this input:
...we would find a class named
max-w-[16rem]']. This PR makes sure we findmax-w-[16rem]instead, while preserving the ability to match things likecontent-['hello']and evencontent-[']'].We don't match this properly yet:
content-['hello[]'], but we also didn't before this PR, so this is still purely an improvement over what was there before.Since the regex is getting long, I've also broken it up into 4 parts with a few comments for each piece to explain what it's for.