Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename --font-family-* variables to --font-* #14885

Merged
merged 3 commits into from
Nov 6, 2024

Conversation

adamwathan
Copy link
Member

@adamwathan adamwathan commented Nov 5, 2024

This PR renames the --font-family-* theme variables to --font-* to more closely match the utility names and be a bit more terse in general.

  @theme {
-   --font-family-sans: ui-sans-serif, system-ui, sans-serif, 'Apple Color Emoji', 'Segoe UI Emoji', 'Segoe UI Symbol', 'Noto Color Emoji';
-   --font-family-serif: ui-serif, Georgia, Cambria, 'Times New Roman', Times, serif;
-   --font-family-mono: ui-monospace, SFMono-Regular, Menlo, Monaco, Consolas, 'Liberation Mono', 'Courier New', monospace;
    
+   --font-sans: ui-sans-serif, system-ui, sans-serif, 'Apple Color Emoji', 'Segoe UI Emoji', 'Segoe UI Symbol', 'Noto Color Emoji';
+   --font-serif: ui-serif, Georgia, Cambria, 'Times New Roman', Times, serif;
+   --font-mono: ui-monospace, SFMono-Regular, Menlo, Monaco, Consolas, 'Liberation Mono', 'Courier New', monospace;
  }

This is part of a bigger set of changes where we're renaming other theme variables as well with the same goals, since many existing theme variables like --shadow-* and --radius-* are already not using the explicit CSS property name.

@adamwathan adamwathan marked this pull request as ready for review November 6, 2024 15:11
@adamwathan adamwathan requested a review from a team as a code owner November 6, 2024 15:11
@adamwathan adamwathan force-pushed the change/rename-font-family-variables-to-font branch from 7012ddd to e2b3021 Compare November 6, 2024 15:12
@adamwathan adamwathan merged commit 2aea6e9 into next Nov 6, 2024
1 check passed
@adamwathan adamwathan deleted the change/rename-font-family-variables-to-font branch November 6, 2024 15:33
tkmcc added a commit to tkmcc/ui that referenced this pull request Nov 19, 2024
Update docs to reflect change in upstream Tailwind CSS v4, see tailwindlabs/tailwindcss#14885
waynegibson added a commit to waynegibson/fonts that referenced this pull request Dec 5, 2024
TailwindCSS v4 had an update to the way you configure theme fonts variables.  See this pull request tailwindlabs/tailwindcss#14885
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants