Speed up template migrations #14679
Merged
Speed up template migrations #14679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thecrypticace
force-pushed
the
fix/v4-fast-template-slicing
branch
2 times, most recently
from
19ad87f to
098a804
Compare
This makes sure that we’re always slicing the original string and not a changing string. This means that we can traverse the candidate replacements forward through the string rather than slicing and applying them in reverse order. A little extra bookkeeping is required but produces a decent speedup in v8.
Instead of using `string-byte-slice` which effectively scans through the entire string every time an index is computed. We can instead scan through the content one time while computing utf-8 and utf-16 positions simultaneously allowing us to properly convert between the two. While we do still do a full string traversal it only happens once.
thecrypticace
force-pushed
the
fix/v4-fast-template-slicing
branch
from
098a804 to
374b076
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does two things: