-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Loosen :is() wrapping rules in applyImportantSelector for more readable output #13900
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thecrypticace
approved these changes
Jul 16, 2024
This was referenced Aug 7, 2024
This solves a critical performance issue in our long list scroll render scene, thanks! Great job! |
This was referenced Aug 12, 2024
This was referenced Sep 1, 2024
This was referenced Sep 5, 2024
This was referenced Sep 13, 2024
This was referenced Sep 17, 2024
This was referenced Sep 22, 2024
This was referenced Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, this is just a small quality of life improvement to the changes made in #10835, intended for a v3.x.
I'm using the
important
selector strategy, and noticed that for most cases, output likecan be reduced to simply
because the nested selector doesn't contain a descendant selector like
.dark .text-citrine-500
. I'm sure the unnecessary:is()
would be removed in minification, but having the "cleanest" possible output for Intellisense would be nice. (Trying to convince my coworkers to get on board, and making the previews feel more "hand-written" might help! 😁)As far as I can tell, this change can't affect the behavior of any possible selector passed in. Feel free to close if you can find a counterexample. Thank you!
Edit: we're switching from the important selector strategy to prefixing, so we won't actually need this, if that affects whether you'll consider it.