Explicitly configure Lightning CSS features, and prefer user browserslist over default browserslist - #11402
Merged
Merged
Conversation
We don't want this to automatically apply since we have dedicated logical property based utilities already. We also have a feature flag to toggle some utilities to make use of logical property based ones. This feature should be opt-in to prevent backwards compatibility (e.g.: RTL sites that _did_ use a mr-4 explicitly).
…rom Lightning CSS
RobinMalfait
force-pushed
the
feat/explicitly-configure-lightningcss
branch
from
June 9, 2023 15:39
1903d69 to
84974b2
Compare
If a custom browserslist config is used, then we don't explicitly set the include/exclude features from Lightning CSS (except for nesting, we always want to process nesting)
RobinMalfait
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR explicitly includes or excludes Lightning CSS features to ensure we have the best possible
output while maintaining backwards compatibility.
A few side effects that this PR includes:
::markerare split when Safari target is used parcel-bundler/lightningcss#508:is()results in duplicate selectors parcel-bundler/lightningcss#509