Skip to content

Commit b8bc6a9

Browse files
Apply suggestions from code review
Co-authored-by: Adam Wathan <adam.wathan@gmail.com>
1 parent efa812f commit b8bc6a9

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

CHANGELOG.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
1818
- _Upgrade (experimental)_: Minify arbitrary values when printing candidates ([#14720](https://github.com/tailwindlabs/tailwindcss/pull/14720))
1919
- _Upgrade (experimental)_: Ensure legacy theme values ending in `1` (like `theme(spacing.1)`) are correctly migrated to custom properties ([#14724](https://github.com/tailwindlabs/tailwindcss/pull/14724))
2020
- _Upgrade (experimental)_: Migrate arbitrary values to bare values for the `from-*`, `via-*`, and `to-*` utilities ([#14725](https://github.com/tailwindlabs/tailwindcss/pull/14725))
21-
- _Upgrade (experimental)_: Reduce the number of false-positive migration of the important modifier (e.g. `!border` to `border!`) ([#14737](https://github.com/tailwindlabs/tailwindcss/pull/14737))
21+
- _Upgrade (experimental)_: Don't migrate important modifiers that are actually logical negations (e.g. `let foo = !border` to `let foo = border!`) ([#14737](https://github.com/tailwindlabs/tailwindcss/pull/14737))
2222

2323
### Changed
2424

packages/@tailwindcss-upgrade/src/template/codemods/important.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ export function important(
3030
// The important migration is one of the most broad migrations with a high
3131
// potential of matching false positives since `!` is a valid character in
3232
// most programming languages. Since v4 is technically backward compatible
33-
// to v3 in that it can read `!` in the front of the utility too, we err
33+
// with v3 in that it can read `!` in the front of the utility too, we err
3434
// on the side of caution and only migrate candidates that we are certain
3535
// are inside of a string.
3636
if (location) {

0 commit comments

Comments
 (0)