Sort template literals in Angular expressions #377
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prettier fixed their parser bug in v3.6 so we just need to check for template literals
thecrypticace
force-pushed
the
fix/angular-expr-template-literals
branch
from
d8b5970 to
0839b56
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prettier fixed their parser bug in v3.6 so we just need to check for and sort template literals inside Angular expressions.
Our tests are not currently running against Prettier v3.6 because of a bug in I think jsdoc. Need to look more into it. I've left in a commented test that passes against Prettier v3.6.
Fixes #368