Fix clicking <Label /> opens <input type="file">
#3707
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where the
<Label>component didn't open the<input type="file">when clicking it.For native elements, the
Labelcomponent already renders a native<label>behind the scenes. Some native elements like<input type="checkbox">immediately change the state of the element whereas some other elements don't such as<select></select>you just get the focus.However,
<input type="file">should also immediately open the file picker when clicking the label and this was not the case. This PR fixes that.Since we are already using a native
<label>and linking the<label>with its<input type="file">performing a.click()is allowed.Fixes: #3680
Test plan
You can play with it here: https://headlessui-react-git-fix-issue-3680-tailwindlabs.vercel.app/combinations/form
This video shows how it behaves now:
Screen.Recording.2025-04-25.at.12.41.42.mov