Fix crash in ListboxOptions when using as={Fragment}
#3513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
RobinMalfait
commented
Oct 8, 2024
| @@ -57,7 +57,16 @@ export type PropsForFeatures<T extends RenderFeatures> = Expand< | |||
| > | |||
| > | |||
|
|
|||
| export function render<TFeature extends RenderFeatures, TTag extends ElementType, TSlot>({ | |||
| export function useRender() { | |||
There was a problem hiding this comment.
Pretty sure we can move way more things in here such that everything is simpler and more optimized. But want to do it in small steps.
This essentially wraps the render(…) function with the useMergeRefsFn() which means every component now gets the useMergeRefsFn() for free.
We already use the `render` function helper in all of our components, but we also need _some_ way of storing persistent functions (such as the `mergeRefsFn`). With this hook, we can embed it in the hook and we can ensure it's always stable. We also won't run into an issue where we accidentally forget something because it will be shipped by default.
RobinMalfait
force-pushed
the
fix/issue-3507
branch
from
5a9afd8
to
769f9f4
Compare
thecrypticace
approved these changes
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where a
Maximum update depth exceedederror occurs if you useas={Fragment}in theListboxOptionscomponent.This PR also includes a refactor to make sure this exact issue cannot happen anymore in other components.
Fixes: #3507