Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure the main tree and parent Dialog components are marked as inert #2290

Merged
merged 6 commits into from
Feb 17, 2023
Merged

Ensure the main tree and parent Dialog components are marked as inert #2290

merged 6 commits into from
Feb 17, 2023

Commits on Feb 16, 2023

  1. drop @ts-expect-error, because inert is available now

    @RobinMalfait
    RobinMalfait committed Feb 16, 2023
    Configuration menu
    Copy the full SHA
    82a264d View commit details
    Browse the repository at this point in the history

  2. fix logical error 

    We want to apply `inert` when we _don't_ have nested dialogs, because if
we _do_ have nested dialogs, then the inert should be applied from the
nested dialog (or visually the top most dialog).
    @RobinMalfait
    RobinMalfait committed Feb 16, 2023
    Configuration menu
    Copy the full SHA
    512b3f4 View commit details
    Browse the repository at this point in the history

Commits on Feb 17, 2023

  1. update changelog

    @RobinMalfait
    RobinMalfait committed Feb 17, 2023
    Configuration menu
    Copy the full SHA
    ba04eb7 View commit details
    Browse the repository at this point in the history

  2. replace useInertOthers with useInert

    @RobinMalfait
    RobinMalfait committed Feb 17, 2023
    Configuration menu
    Copy the full SHA
    ad335e6 View commit details
    Browse the repository at this point in the history

  3. add assertInert and assertNotInert accessibility assertion helpers

    @RobinMalfait
    RobinMalfait committed Feb 17, 2023
    Configuration menu
    Copy the full SHA
    e763b1a View commit details
    Browse the repository at this point in the history

  4. ensure the main tree root is marked as inert 

    As well as the parent dialogs in case of nested dialogs.
    @RobinMalfait
    RobinMalfait committed Feb 17, 2023
    Configuration menu
    Copy the full SHA
    54ce6e4 View commit details
    Browse the repository at this point in the history