Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Support for IAM Service Accounts in GCP #713

Merged
merged 2 commits into from
Apr 10, 2023
Merged

Add Support for IAM Service Accounts in GCP #713

merged 2 commits into from
Apr 10, 2023

Conversation

ShubhamPalriwala
Copy link
Contributor

Problem

Closes #670

Solution

Screenshot_2023-04-07-22-51-12_4920x1920

Checklist

  • Code follows the contributing guidelines
  • Changes have been thoroughly tested
  • Documentation has been updated, if necessary
  • Any dependencies have been added to the project, if necessary

@mlabouardy mlabouardy added the gcp label Apr 8, 2023
@mlabouardy mlabouardy added this to the v3.0.12 milestone Apr 8, 2023
@ShubhamPalriwala
Copy link
Contributor Author

Merged develop, and tested the functionality post it, works as expected!

mlabouardy
mlabouardy approved these changes Apr 10, 2023
View reviewed changes
Copy link
Collaborator

@mlabouardy mlabouardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! thanks a lot @ShubhamPalriwala

@mlabouardy mlabouardy merged commit 29fb8b3 into tailwarden:develop Apr 10, 2023
@ShubhamPalriwala ShubhamPalriwala mentioned this pull request Apr 12, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mlabouardy mlabouardy mlabouardy approved these changes

Assignees
No one assigned
Labels
gcp
Projects
None yet
Milestone
v3.0.12
Development

Successfully merging this pull request may close these issues.
2 participants
@ShubhamPalriwala @mlabouardy