From eccd6366d1be82f8df741718dcdd586eea618221 Mon Sep 17 00:00:00 2001 From: Roland Shoemaker Date: Fri, 23 Sep 2022 18:41:02 -0700 Subject: [PATCH] acme/autocert: remove TestRenewFromCache skips Removes the skips from TestRenewFromCache and TestRenewFromCacheAlreadyRenewed, which were added due to flakes which may have been fixed by the renewal timer change. Updates golang/go#51080 Change-Id: Ib953a24e610e89dfbbea450a4c257c105055ce7e Reviewed-on: https://go-review.googlesource.com/c/crypto/+/433815 Run-TryBot: Roland Shoemaker Auto-Submit: Roland Shoemaker TryBot-Result: Gopher Robot Reviewed-by: Bryan Mills --- acme/autocert/renewal_test.go | 19 ------------------- 1 file changed, 19 deletions(-) diff --git a/acme/autocert/renewal_test.go b/acme/autocert/renewal_test.go index 460a384255..ffe4af2a5c 100644 --- a/acme/autocert/renewal_test.go +++ b/acme/autocert/renewal_test.go @@ -8,7 +8,6 @@ import ( "context" "crypto" "crypto/ecdsa" - "runtime" "testing" "time" @@ -43,15 +42,6 @@ func TestRenewalNext(t *testing.T) { } func TestRenewFromCache(t *testing.T) { - if runtime.GOOS == "windows" && runtime.GOARCH == "arm64" { - // This test was observed to fail frequently in Dial with "connectex: No - // connection could be made because the target machine actively refused it." - // - // Failures started around CL 381715, so it looks to me (bcmills) like an - // undiagnosed bug in (or exposed by) acmetest.CAServer. - t.Skipf("skipping test on windows/arm64: see https://go.dev/issue/51080") - } - man := testManager(t) man.RenewBefore = 24 * time.Hour @@ -137,15 +127,6 @@ func TestRenewFromCache(t *testing.T) { } func TestRenewFromCacheAlreadyRenewed(t *testing.T) { - if runtime.GOOS == "windows" && runtime.GOARCH == "arm64" { - // This test was observed to fail frequently in Dial with "connectex: No - // connection could be made because the target machine actively refused it." - // - // Failures started around CL 381715, so it looks to me (bcmills) like an - // undiagnosed bug in (or exposed by) acmetest.CAServer. - t.Skipf("skipping test on windows/arm64: see https://go.dev/issue/51080") - } - ca := acmetest.NewCAServer(t).Start() man := testManager(t) man.RenewBefore = 24 * time.Hour